Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE11 on clicking on transcript will throw exception of matches #4387

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Aug 10, 2022

Fixes #4386.

Changelog Entry

Fixed

  • Fixes #4386. Clicking on Adaptive Cards should not throw exception under IE11, by @compulim, in PR #4387, also fixed:
    • Prop type warning should not be shown for <ActivityRow>

Description

HTMLElement.matches needs to be vendor-prefixed to HTMLElement.msMatchesSelector in IE11.

Specific Changes

  • Updated all occurrences of HTMLElement.matches to fallback to HTMLElement.msMatchesSelector
  • Added displayName to some React component for debuggability
  • Changed children: PropTypes to any as the previous combination actually showing warning on wrong prop type
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim merged commit 7969fde into microsoft:main Aug 10, 2022
@compulim compulim deleted the fix-ie11-matches branch August 10, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE11: Click on Adaptive Cards should not throw exception
2 participants