Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blob URL to list of allowed protocols #4233

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Add blob URL to list of allowed protocols #4233

merged 3 commits into from
Apr 6, 2022

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Apr 6, 2022 •
edited
Loading

Fixes #4232.

Changelog Entry

Fixed

  • Fixes #4232. Added blob: to allowed protocol list for file attachment UI (<FileContent>), by @compulim in PR #4233

Description

When displaying <FileContent>, make blob URL has downloadable.

Design

In #4143, we decided not to add blob: because DirectLineJS is coded in a way it will never send a blob: protocol.

However, some other chat adapters may use this UI with a blob: protocol.

We should add blob: to list of allowed protocol.

Specific Changes

  • Add blob: to allowed protocol list in <FileContent>
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review April 6, 2022 18:01
@compulim
Copy link
Contributor Author

compulim commented Apr 6, 2022

Thanks @tonyanziano!

@compulim compulim merged commit 6a5359f into microsoft:main Apr 6, 2022
@compulim compulim deleted the fix-file-content-blob-url branch April 6, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@beyackle beyackle Awaiting requested review from beyackle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "blob:" to list of allowed protocol for file attachment UI
2 participants
@compulim @tonyanziano