Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 4.14.1 for release #4045

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Bump to 4.14.1 for release #4045

merged 2 commits into from
Sep 7, 2021

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 2, 2021

(Related to #4044)

(Changelog includes everything to be released for 4.14.1)

Changelog Entry

Fixed

Changed

Description

Bumping to 4.14.1 and prepare for release.

Design

Bumping dependencies for security fixes.

Specific Changes

(Please refer to associated PRs)

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@cwhitten
Copy link
Member

cwhitten commented Sep 2, 2021

@compulim why is CI failing?

@compulim
Copy link
Contributor Author

compulim commented Sep 3, 2021

Will investigate CI failures... seems reliability and never saw this test fail in the past (history of unreliabilities).

__tests__/inputHint.js › input hint of expectingInput should turn on microphone if initiated via microphone

Error: expect(received).resolves.toBeTruthy()

Received: false
at Object.toBeTruthy 

@compulim
Copy link
Contributor Author

compulim commented Sep 7, 2021

Added retry-wait because we use useEffect to start the speech recognition engine. And React render() could be a bit slower under load.

Although retry-wait will make it more reliable, it's like 99% more reliable. Adding #4046 to make it 100% bulletproof.

@cwhitten cwhitten merged commit 1b842df into microsoft:main Sep 7, 2021
@compulim compulim deleted the bump-4.14.1 branch September 8, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move react-scripts to devDependencies Typing of usePerformCardAction() hook is wrong
2 participants