Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
p-defer
, by @compulim, in PR #3978Description
When working on #3974, we imported
p-defer
instead ofp-defer-es5
. Since our build pipeline is configured not to transpile anything fromnode_modules/*
, thus, we are putting non-ES5 code inwebchat-es5.js
.Design
Import from
p-defer-es5
instead. In other part of our code, we also importp-defer-es5
instead. It is a package that transpilep-defer
onnpm install
-time.Specific Changes
packages/bundle/src/speech/CustomAudioInputStream.ts
to usep-defer-es5
insteadI have added tests and executed them locally(Will test it in release testing)CHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)CSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)