Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use p-defer-es5 instead #3978

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Use p-defer-es5 instead #3978

merged 2 commits into from
Jul 7, 2021

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jul 7, 2021

Fixes #3977.

Changelog Entry

Fixed

  • Fixes #3977. Fix bundle not work in Internet Explorer 11 due to p-defer, by @compulim, in PR #3978

Description

When working on #3974, we imported p-defer instead of p-defer-es5. Since our build pipeline is configured not to transpile anything from node_modules/*, thus, we are putting non-ES5 code in webchat-es5.js.

Design

Import from p-defer-es5 instead. In other part of our code, we also import p-defer-es5 instead. It is a package that transpile p-defer on npm install-time.

Specific Changes

  • Update packages/bundle/src/speech/CustomAudioInputStream.ts to use p-defer-es5 instead
  • I have added tests and executed them locally (Will test it in release testing)
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review July 7, 2021 17:19
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@compulim compulim merged commit 37998a9 into microsoft:main Jul 7, 2021
@compulim compulim deleted the fix-3977-ie11 branch July 7, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p-defer is impacting ES5 build
3 participants