Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclusive padding for suggested actions flippers #3704

Merged
merged 14 commits into from
Feb 9, 2021

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Feb 4, 2021

Fixes #3612.

Changelog Entry

Fixed

Description

Add exclusive paddings for flippers for suggested actions in carousel mode.

Design

Specific Changes

  • Adds exclusive paddings for suggested actions flippers
  • Always show the flippers
  • Removes text-overflow: ellipsis for carousel to enable buttons to be longer than the container (this is a regressed bug in RTL only)
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@corinagum corinagum self-assigned this Feb 4, 2021
@compulim compulim changed the title [DRAFT] Add exclusive padding for suggested actions flippers Add exclusive padding for suggested actions flippers Feb 5, 2021
@compulim compulim marked this pull request as ready for review February 5, 2021 12:40
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corinagum corinagum merged commit a279a8d into microsoft:master Feb 9, 2021
@compulim compulim mentioned this pull request Mar 2, 2021
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel option is unclickable for option with short name
2 participants