Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wait for 4.6] Created Clear Conversation After Idle Sample #2375

Merged
merged 12 commits into from
Nov 13, 2019

Conversation

tdurnford
Copy link
Contributor

@tdurnford tdurnford commented Sep 3, 2019

Fixes #497

Changelog Entry

Clear Conversation After Idle, by @tdurnford, in PR #2375

Description

Created sample that replaces to store to clear the conversation after the user idles for 30 seconds.

  • Testing Added
    Tests aren't need for samples

@corinagum
Copy link
Contributor

lol, IMO, there's no point in 'jumping to the completed code' if you don't have a section explaining what the code does. :P

@tdurnford
Copy link
Contributor Author

Lol it's a draft :P

@corinagum
Copy link
Contributor

Can't be merged until after 4.6 release

@corinagum corinagum changed the title Created Clear Conversation After Idle Sample [Do not merge] Created Clear Conversation After Idle Sample Sep 10, 2019
@corinagum corinagum changed the title [Do not merge] Created Clear Conversation After Idle Sample [Wait for 4.6] Created Clear Conversation After Idle Sample Sep 12, 2019
@corinagum corinagum added the 4.6 label Sep 12, 2019
@tdurnford tdurnford marked this pull request as ready for review November 1, 2019 21:47
@coveralls
Copy link

coveralls commented Nov 1, 2019

Coverage Status

Coverage remained the same at 63.345% when pulling bfe56c4 on tdurnford:497 into 9b06bcc on microsoft:master.

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure it gets deployed like sample 23 needs to be?

@tdurnford tdurnford merged commit 39f7c70 into microsoft:master Nov 13, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample: Clear chat history after user idle
3 participants