-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send welcome event and fixes around speech sagas #1286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
305e868
to
62448a6
Compare
Fixes #1371 |
Closed
238927e
to
63424bd
Compare
cwhitten
reviewed
Dec 26, 2018
packages/core/src/sagas/markAllAsSpokenOnStopSpeakActivitySaga.js
Outdated
Show resolved
Hide resolved
packages/core/src/sagas/clearSuggestedActionsOnPostActivitySaga.js
Outdated
Show resolved
Hide resolved
packages/core/src/sagas/startSpeakActivityOnPostActivitySaga.js
Outdated
Show resolved
Hide resolved
cwhitten
reviewed
Dec 27, 2018
b0b88ed
to
de14d4e
Compare
2439bbd
to
2e4d5b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Since
conversationUpdate
was not designed for welcome scenario, it lacks of important features required for welcome, e.g. ability to send browser language and information to the bot as the first message.This PR was designed to add a sample for send welcome event.
But during coding the sample, we talked to
redux-saga
team because one of their design decision is affecting our code. We settled with their design decision but that forced us to add an interim action (CONNECT_FULFILLING
). We revisited all sagas to make sure they can handle successive actions properly.While revisiting all sagas, we also identified few problematic areas in our sagas:
sendEvent
will stop speaking, behave same as otherpostActivity
helpersvia
argument insetSendBox
is never used, removedAlthough this PR was originally targeted to add a sample with minor-but-broad change on all sagas, since we practically touched almost every sagas, we also revisited problematic areas to make sure they are working as expected.
CHANGELOG.md
Added
sendEvent
, in PR #1286CONNECT_FULFILLING
action to workaroundredux-saga
design decision, in PR #1286Fixed
incomingActivitySaga
may throw null-ref exception if the first activity is from user, in PR #1286ignoringInput
, in PR #1286Samples