Fix JsonNumber bson serialization #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always use the right number type when serializing, so formats that support the type info can deserialize to the correct type - Fix fallback deserialization of custom Number implementations - Fix element index increment when serializing BigInteger
|
|
dstepanov
requested changes
Jul 24, 2024
| @@ -279,6 +279,11 @@ protected Number getBestNumber() { | |||
| }; | |||
| } | |||
|
|
|||
| @Override | |||
| protected BigDecimal getBigDecimalFromNumber(Number number) { | |||
| return ((Decimal128) number).bigDecimalValue(); | |||
There was a problem hiding this comment.
This can be implemented using instanceOf or different convertions
yawkat
reviewed
Jul 24, 2024
| * @throws UnsupportedOperationException If custom number types are not expected | ||
| */ | ||
| protected BigDecimal getBigDecimalFromNumber(Number number) { | ||
| throw new UnsupportedOperationException(); |
There was a problem hiding this comment.
Definitely needs a proper default implementation.
|
Thanks for the PR. I have corrected the new method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int JsonNumber, when deserializing you get along JsonNumber.Numberimplementations. The bson decoder advances whengetBigDecimalis called - so, in the second call you either get an exception or one of the fields is swallowed.BigInteger. Increment is already done byencodeBigDecimal.