Fixed concurrency issue in ObjectDeserializer

[msupic]

No description provided.

[graemerocher]

stack overflows so probably not the solution

[dstepanov]

I will try to fix it

[timyates]

@dstepanov I'm likely wrong, but could the fix be:

    @Override
    public <T> DeserBean<T> getDeserializableBean(Argument<T> type, DecoderContext decoderContext) throws SerdeException {
        TypeKey key = new TypeKey(type);
        DeserBean<T> deserBeanSupplier = (DeserBean) deserBeanMap.get(key);
        if (deserBeanSupplier == null) {
            synchronized (deserBeanMap) { // double check
                deserBeanSupplier = (DeserBean) deserBeanMap.get(key);
                if (deserBeanSupplier == null) {
                    deserBeanSupplier = createDeserBean(type, decoderContext);
                    deserBeanMap.put(key, (DeserBean) deserBeanSupplier);
                    deserBeanSupplier.initialize(decoderContext);
                }
            }
        }
        return deserBeanSupplier;
    }

?

[yawkat]

@timyates no, there is still a data race between the put and the unguarded get in that fix. put must come after the initialize somehow

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[dstepanov]

@graemerocher Fixed