Integrate Micronaut Data and Micrometer to enable tracing SQL queries #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracing details from the example app |
n0tl3ss
approved these changes
Jan 22, 2025
graemerocher
requested changes
Jan 22, 2025
...c/main/java/io/micronaut/micrometer/observation/datasource/ObservationDataSourceFactory.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/micronaut/micrometer/observation/datasource/ObservationDataSourceFactory.java
Show resolved
Hide resolved
...c/main/java/io/micronaut/micrometer/observation/datasource/ObservationDataSourceFactory.java
Outdated
Show resolved
Hide resolved
| */ | ||
| @Singleton | ||
| @Primary | ||
| public class ProxyDataSourceResolver implements DataSourceResolver { |
There was a problem hiding this comment.
should this be here or upstream in Micronaut-sql?
There was a problem hiding this comment.
should it be public? Is it public API?
There was a problem hiding this comment.
Removed public, not needed. I think it should not go to micronaut-sql because it would introduce dependency on datasource-micrometer and now will be activated only if this module is added so I would leave it here.
Something similar might be needed for micronaut-tracing OpenTelemetryDataSource but didn't see a way to unwrap it.
graemerocher
approved these changes
Jan 22, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.