Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject MeterRegistry inside filters as a provider #800

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

n0tl3ss
Copy link
Member

@n0tl3ss n0tl3ss commented Jul 23, 2024

MeterRegistry should be injected as Provider. That will ensure that Meter registry is closed before the clients. This is needed because meter registry could use an http client for sending metrics.

Copy link

@graemerocher graemerocher added the type: improvement A minor improvement to an existing feature label Jul 23, 2024
@graemerocher graemerocher merged commit b29c296 into 5.7.x Jul 23, 2024
11 checks passed
@graemerocher graemerocher deleted the inject-meter-registry-as-provider branch July 23, 2024 11:36
*/
public ClientRequestMetricRegistryFilter(MeterRegistry meterRegistry) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have kept the other constructor and deprecate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants