inject MeterRegistry inside filters as a provider #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
graemerocher
added
the
type: improvement
graemerocher
approved these changes
Jul 23, 2024
sdelamo
reviewed
Oct 29, 2024
| */ | ||
| public ClientRequestMetricRegistryFilter(MeterRegistry meterRegistry) { |
There was a problem hiding this comment.
We should have kept the other constructor and deprecate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MeterRegistry should be injected as Provider. That will ensure that Meter registry is closed before the clients. This is needed because meter registry could use an http client for sending metrics.