Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent unmatched urls to pollute metrics #626

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

s15r
Copy link
Contributor

@s15r s15r commented Nov 7, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a new test which I think it represents the problem more clearly.

@sdelamo sdelamo added the type: bug Something isn't working label Nov 8, 2023
@sdelamo sdelamo requested a review from graemerocher November 8, 2023 15:58
@graemerocher
Copy link
Contributor

probably will need to be back ported to previous releases

@sdelamo sdelamo requested a review from graemerocher November 8, 2023 16:30
@sdelamo sdelamo merged commit c77a2bc into micronaut-projects:master Nov 8, 2023
sdelamo added a commit that referenced this pull request Nov 10, 2023
* prevent unmatched urls to pollute metrics

* simpler test

* reuse existing UNKNOWN constant

---------

Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants