Fix java 21

[wetted]

Supersedes #605 to stop micronaut-build force pushing it all the time

[wetted]

This is puzzling to me. MetricsMicronautSerializationTest fails on Java 21 (passes for 17) where it expects meters with names "executor.completed", "executor.queued" but only "executor" esists. I think it has something to do with the Java 21 virtual support, but I created a project with the same test for Java 21 and it passes. I don''t know yet why it passes for my project and fails for the module. https://github.com/wetted/executor-metrics

The difference (between jdk17 and jdk21) is in what is coming from the micrometer library CompositeMetricsRegistry when MetricsEndpoint is initialized...but that still doesn't explain why my standalone example works. In that case the CompositeMetricsRegistry has the expected meters for "executor.completed" and "executor.queued".

[timyates]

So the issue seems to be that

Oct 30, 2023 10:26:47 AM io.micrometer.core.instrument.binder.jvm.ExecutorServiceMetrics bindTo
WARNING: Failed to bind as java.util.concurrent.ThreadPerTaskExecutor is unsupported.

That is, it's failing to bind the metrics here in micrometer https://github.com/micrometer-metrics/micrometer/blob/main/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/ExecutorServiceMetrics.java#L304

This is called from our binder here:

micronaut-micrometer/micrometer-core/src/main/java/io/micronaut/configuration/metrics/binder/executor/ExecutorServiceMetricsBinder.java

Line 81 in 98109ea

new ExecutorServiceMetrics(unwrapped, beanIdentifier.getName(), tags).bindTo(meterRegistry);

I can't find an issue in Micrometer itself 🤔

The test passes if we turn off the virtual executor via

@Property(name = "micronaut.executors.virtual.enabled", value = "false")

on the test... but I'm not sure if this is a fix, a workaround, or a hack

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information