Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 288 Percentile configuration added to http server and client metrics #338

Merged
merged 4 commits into from
Jan 11, 2022

Conversation

umutkocasarac
Copy link
Contributor

Percentile configuration added to HTTP server and client metrics. Necessary configuration can be passed like below

micronaut.metrics..web.client.percentiles=0.95,0.99
micronaut.metrics..web.server.percentiles=0.95,0.99

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2022

CLA assistant check
All committers have signed the CLA.

@graemerocher
Copy link
Contributor

could you perform the commits with the same github account and email as submitted the PR? Otherwise the CLA approval won't work

@umutkocasarac
Copy link
Contributor Author

sorry, I should have built it locally before creating PR. It was complaining about the copyright and Javadoc, and I just fixed them.

@umutkocasarac
Copy link
Contributor Author

@graemerocher Let me know if I need to provide any other information for the PR

@graemerocher graemerocher merged commit 02ceec4 into micronaut-projects:master Jan 11, 2022
@graemerocher
Copy link
Contributor

Thanks for the contribution!

@umutkocasarac
Copy link
Contributor Author

thanks, @graemerocher.

I don't see this PR is associated with the issue If there is anything I can do for that let me know.

@wbeard
Copy link

wbeard commented Aug 19, 2022

Hey @umutkocasarac & @graemerocher, do you all know if this has been officially documented anywhere? I'm glad I found this issue & I appreciate your work @umutkocasarac. In an application.yml file, would you just have:

  metrics:
  ...
  http:
    ...
    server:
      ...
      percentiles:
        - 0.95
        - 0.99

@wbeard
Copy link

wbeard commented Aug 19, 2022

I actually found this out by digging through the source:

metrics:
  binders:
    web:
      server:
        percentiles: "0.95,0.99"

I didn't find documentation on "binders", so I'm not sure where one might contribute this config to the documentation?

@umutkocasarac
Copy link
Contributor Author

Hi @wbeard sorry for the late reply. Unfortunately, I didn't add any documentation apart from unit tests however this doc seems like a proper place to document this option.

scprek added a commit to scprek/micronaut-micrometer that referenced this pull request Jan 30, 2023
scprek added a commit to scprek/micronaut-micrometer that referenced this pull request Jan 30, 2023
sdelamo pushed a commit that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants