-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 288 Percentile configuration added to http server and client metrics #338
Issue 288 Percentile configuration added to http server and client metrics #338
Conversation
could you perform the commits with the same github account and email as submitted the PR? Otherwise the CLA approval won't work |
e9917c1
to
113309e
Compare
sorry, I should have built it locally before creating PR. It was complaining about the copyright and Javadoc, and I just fixed them. |
@graemerocher Let me know if I need to provide any other information for the PR |
Thanks for the contribution! |
thanks, @graemerocher. I don't see this PR is associated with the issue If there is anything I can do for that let me know. |
Hey @umutkocasarac & @graemerocher, do you all know if this has been officially documented anywhere? I'm glad I found this issue & I appreciate your work @umutkocasarac. In an metrics:
...
http:
...
server:
...
percentiles:
- 0.95
- 0.99 |
I actually found this out by digging through the source: metrics:
binders:
web:
server:
percentiles: "0.95,0.99" I didn't find documentation on "binders", so I'm not sure where one might contribute this config to the documentation? |
Percentile configuration added to HTTP server and client metrics. Necessary configuration can be passed like below
micronaut.metrics..web.client.percentiles=0.95,0.99
micronaut.metrics..web.server.percentiles=0.95,0.99