Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Reactor as implementation detail and fix tests #275

Merged
merged 5 commits into from
Jul 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
projectVersion=4.0.0-SNAPSHOT
micronautDocsVersion=2.0.0.RC1
micronautVersion=2.5.7
micronautVersion=3.0.0-M4
micronautTestVersion=2.3.3
groovyVersion=3.0.8
spockVersion=2.0-groovy
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package io.micronaut.micrometer.annotation.processing

import io.micronaut.annotation.processing.test.AbstractTypeElementSpec
import io.micronaut.aop.Intercepted
import io.micronaut.ast.transform.test.AbstractBeanDefinitionSpec

class GroovyAnnotationMappingSpec extends AbstractBeanDefinitionSpec {
class GroovyAnnotationMappingSpec extends AbstractTypeElementSpec {

void 'test map timedset annotation'() {
given:
Expand Down
2 changes: 1 addition & 1 deletion micrometer-core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ dependencies {

api "io.micrometer:micrometer-core:$micrometerVersion"
api "io.micronaut:micronaut-inject:$micronautVersion"
api "io.micronaut.reactor:micronaut-reactor"
implementation "io.projectreactor:reactor-core"
compileOnly "io.micronaut:micronaut-management"
compileOnly "io.micronaut.sql:micronaut-jdbc"
compileOnly 'io.micronaut.cache:micronaut-cache-core'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import io.micronaut.http.HttpRequest
import io.micronaut.http.HttpStatus
import io.micronaut.http.annotation.Controller
import io.micronaut.http.annotation.Get
import io.micronaut.http.client.RxHttpClient
import io.micronaut.http.client.HttpClient
import io.micronaut.runtime.server.EmbeddedServer
import jakarta.inject.Singleton
import reactor.core.publisher.Mono
Expand Down Expand Up @@ -66,10 +66,10 @@ class FilteredMetricsEndpointSpec extends Specification {

void "warm up the server"() {
given:
RxHttpClient rxClient = RxHttpClient.create(embeddedServer.getURL())
HttpClient client = HttpClient.create(embeddedServer.getURL())

expect:
rxClient.exchange(HttpRequest.GET('/filtered/hello/fred'), String).blockingFirst().body() == "Hello Fred"
client.toBlocking().exchange(HttpRequest.GET('/filtered/hello/fred'), String).body() == "Hello Fred"
}

void "test the filter beans are available"() {
Expand All @@ -86,7 +86,7 @@ class FilteredMetricsEndpointSpec extends Specification {
@IgnoreIf({env["CI"]})
void "test metrics endpoint with filtered metrics"() {
given:
RxHttpClient rxClient = RxHttpClient.create(embeddedServer.getURL())
HttpClient client = HttpClient.create(embeddedServer.getURL())

when:
ApplicationContext context = embeddedServer.getApplicationContext()
Expand All @@ -101,28 +101,28 @@ class FilteredMetricsEndpointSpec extends Specification {

when:

def result = waitForResponse(rxClient)
def result = waitForResponse(client)

then:
result.names.size() == 1
!result.names[0].toString().startsWith("system")

cleanup:
rxClient.close()
client.close()
}

Map waitForResponse(RxHttpClient rxClient, Integer loopCount = 1) {
Map waitForResponse(HttpClient client, Integer loopCount = 1) {
if (loopCount > 5) {
throw new RuntimeException("Too many attempts to get metrics, failed!")
}

def response = rxClient.exchange("/metrics", Map).blockingFirst()
def response = client.toBlocking().exchange("/metrics", Map)
Map result = response?.body()
log.info("/metrics returned status=${response?.status()} data=${result}")
if (!(result?.names?.size() > 0) || response?.status() != HttpStatus.OK) {
Thread.sleep(500)
log.info("Could not get metrics, retrying attempt $loopCount of 5")
waitForResponse(rxClient, loopCount + 1)
waitForResponse(client, loopCount + 1)
} else {
return result
}
Expand Down
Loading