Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nettyVersion. #187

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Remove nettyVersion. #187

merged 2 commits into from
Dec 2, 2020

Conversation

alvarosanchez
Copy link
Member

Closes #134

@alvarosanchez alvarosanchez requested a review from ilopmar December 2, 2020 12:22
ilopmar
ilopmar suggested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@ilopmar ilopmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two different Netty versions:

image

4.1.54 from micronaut-bom https://github.com/micronaut-projects/micronaut-core/blob/v2.2.0/gradle.properties#L105 and another one from any other place

@alvarosanchez
Copy link
Member Author

Refresh your project

$ ./gradlew micrometer-core:dependencies | grep "io.netty"
     +--- io.netty:netty-bom:4.1.54.Final
+--- io.netty:netty-buffer -> 4.1.54.Final
|    \--- io.netty:netty-common:4.1.54.Final
+--- io.netty:netty-transport -> 4.1.54.Final
|    +--- io.netty:netty-common:4.1.54.Final
|    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    \--- io.netty:netty-resolver:4.1.54.Final
|         \--- io.netty:netty-common:4.1.54.Final
+--- io.netty:netty-transport-native-epoll -> 4.1.54.Final
|    +--- io.netty:netty-common:4.1.54.Final
|    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    +--- io.netty:netty-transport:4.1.54.Final (*)
|    \--- io.netty:netty-transport-native-unix-common:4.1.54.Final
|         +--- io.netty:netty-common:4.1.54.Final
|         +--- io.netty:netty-buffer:4.1.54.Final (*)
|         \--- io.netty:netty-transport:4.1.54.Final (*)
+--- io.netty:netty-transport-native-kqueue -> 4.1.54.Final
|    +--- io.netty:netty-common:4.1.54.Final
|    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    +--- io.netty:netty-transport:4.1.54.Final (*)
|    \--- io.netty:netty-transport-native-unix-common:4.1.54.Final (*)
|    |    |    \--- io.netty:netty-buffer:4.1.54.Final (*)
|    |    +--- io.netty:netty-codec-http:4.1.54.Final
|    |    |    +--- io.netty:netty-common:4.1.54.Final
|    |    |    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |    |    +--- io.netty:netty-transport:4.1.54.Final (*)
|    |    |    +--- io.netty:netty-codec:4.1.54.Final
|    |    |    |    +--- io.netty:netty-common:4.1.54.Final
|    |    |    |    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |    |    |    \--- io.netty:netty-transport:4.1.54.Final (*)
|    |    |    \--- io.netty:netty-handler:4.1.54.Final
|    |    |         +--- io.netty:netty-common:4.1.54.Final
|    |    |         +--- io.netty:netty-resolver:4.1.54.Final (*)
|    |    |         +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |    |         +--- io.netty:netty-transport:4.1.54.Final (*)
|    |    |         \--- io.netty:netty-codec:4.1.54.Final (*)
|    |    +--- io.netty:netty-handler:4.1.54.Final (*)
|    |    \--- io.netty:netty-codec-http2:4.1.54.Final
|    |         +--- io.netty:netty-common:4.1.54.Final
|    |         +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |         +--- io.netty:netty-transport:4.1.54.Final (*)
|    |         +--- io.netty:netty-codec:4.1.54.Final (*)
|    |         +--- io.netty:netty-handler:4.1.54.Final (*)
|    |         \--- io.netty:netty-codec-http:4.1.54.Final (*)
|    \--- io.netty:netty-codec-http:4.1.54.Final (*)
     +--- io.netty:netty-bom:4.1.54.Final
     |    +--- io.netty:netty-buffer:4.1.54.Final (c)
     |    +--- io.netty:netty-transport:4.1.54.Final (c)
     |    +--- io.netty:netty-transport-native-epoll:4.1.54.Final (c)
     |    +--- io.netty:netty-transport-native-kqueue:4.1.54.Final (c)
     |    +--- io.netty:netty-codec-http:4.1.54.Final (c)
     |    +--- io.netty:netty-common:4.1.54.Final (c)
     |    +--- io.netty:netty-resolver:4.1.54.Final (c)
     |    +--- io.netty:netty-transport-native-unix-common:4.1.54.Final (c)
     |    +--- io.netty:netty-codec:4.1.54.Final (c)
     |    +--- io.netty:netty-handler:4.1.54.Final (c)
     |    \--- io.netty:netty-codec-http2:4.1.54.Final (c)
+--- io.netty:netty-buffer (n)
+--- io.netty:netty-transport (n)
+--- io.netty:netty-transport-native-epoll (n)
+--- io.netty:netty-transport-native-kqueue (n)
     +--- io.netty:netty-bom:4.1.54.Final
|    |    |    \--- io.netty:netty-buffer:4.1.54.Final
|    |    |         \--- io.netty:netty-common:4.1.54.Final
|    |    +--- io.netty:netty-codec-http:4.1.54.Final
|    |    |    +--- io.netty:netty-common:4.1.54.Final
|    |    |    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |    |    +--- io.netty:netty-transport:4.1.54.Final
|    |    |    |    +--- io.netty:netty-common:4.1.54.Final
|    |    |    |    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |    |    |    \--- io.netty:netty-resolver:4.1.54.Final
|    |    |    |         \--- io.netty:netty-common:4.1.54.Final
|    |    |    +--- io.netty:netty-codec:4.1.54.Final
|    |    |    |    +--- io.netty:netty-common:4.1.54.Final
|    |    |    |    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |    |    |    \--- io.netty:netty-transport:4.1.54.Final (*)
|    |    |    \--- io.netty:netty-handler:4.1.54.Final
|    |    |         +--- io.netty:netty-common:4.1.54.Final
|    |    |         +--- io.netty:netty-resolver:4.1.54.Final (*)
|    |    |         +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |    |         +--- io.netty:netty-transport:4.1.54.Final (*)
|    |    |         \--- io.netty:netty-codec:4.1.54.Final (*)
|    |    +--- io.netty:netty-handler:4.1.54.Final (*)
|    |    \--- io.netty:netty-codec-http2:4.1.54.Final
|    |         +--- io.netty:netty-common:4.1.54.Final
|    |         +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |         +--- io.netty:netty-transport:4.1.54.Final (*)
|    |         +--- io.netty:netty-codec:4.1.54.Final (*)
|    |         +--- io.netty:netty-handler:4.1.54.Final (*)
|    |         \--- io.netty:netty-codec-http:4.1.54.Final (*)
|    \--- io.netty:netty-handler-proxy:4.1.54.Final
|         +--- io.netty:netty-common:4.1.54.Final
|         +--- io.netty:netty-buffer:4.1.54.Final (*)
|         +--- io.netty:netty-transport:4.1.54.Final (*)
|         +--- io.netty:netty-codec:4.1.54.Final (*)
|         +--- io.netty:netty-codec-socks:4.1.54.Final
|         |    +--- io.netty:netty-common:4.1.54.Final
|         |    +--- io.netty:netty-buffer:4.1.54.Final (*)
|         |    +--- io.netty:netty-transport:4.1.54.Final (*)
|         |    \--- io.netty:netty-codec:4.1.54.Final (*)
|         \--- io.netty:netty-codec-http:4.1.54.Final (*)
+--- io.netty:netty-buffer -> 4.1.54.Final (*)
+--- io.netty:netty-transport -> 4.1.54.Final (*)
+--- io.netty:netty-transport-native-epoll -> 4.1.54.Final
|    +--- io.netty:netty-common:4.1.54.Final
|    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    +--- io.netty:netty-transport:4.1.54.Final (*)
|    \--- io.netty:netty-transport-native-unix-common:4.1.54.Final
|         +--- io.netty:netty-common:4.1.54.Final
|         +--- io.netty:netty-buffer:4.1.54.Final (*)
|         \--- io.netty:netty-transport:4.1.54.Final (*)
+--- io.netty:netty-transport-native-kqueue -> 4.1.54.Final
|    +--- io.netty:netty-common:4.1.54.Final
|    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    +--- io.netty:netty-transport:4.1.54.Final (*)
|    \--- io.netty:netty-transport-native-unix-common:4.1.54.Final (*)
|    \--- io.netty:netty-codec-http:4.1.54.Final (*)
|    +--- io.netty:netty-bom:4.1.54.Final
|    |    +--- io.netty:netty-buffer:4.1.54.Final (c)
|    |    +--- io.netty:netty-transport:4.1.54.Final (c)
|    |    +--- io.netty:netty-transport-native-epoll:4.1.54.Final (c)
|    |    +--- io.netty:netty-transport-native-kqueue:4.1.54.Final (c)
|    |    +--- io.netty:netty-handler-proxy:4.1.54.Final (c)
|    |    +--- io.netty:netty-codec-http:4.1.54.Final (c)
|    |    +--- io.netty:netty-common:4.1.54.Final (c)
|    |    +--- io.netty:netty-resolver:4.1.54.Final (c)
|    |    +--- io.netty:netty-transport-native-unix-common:4.1.54.Final (c)
|    |    +--- io.netty:netty-codec:4.1.54.Final (c)
|    |    +--- io.netty:netty-codec-socks:4.1.54.Final (c)
|    |    +--- io.netty:netty-handler:4.1.54.Final (c)
|    |    \--- io.netty:netty-codec-http2:4.1.54.Final (c)
+--- io.netty:netty-buffer (n)
+--- io.netty:netty-transport (n)
+--- io.netty:netty-transport-native-epoll (n)
+--- io.netty:netty-transport-native-kqueue (n)
|    |    +--- io.netty:netty-bom:4.1.54.Final
|    |    |    +--- io.netty:netty-buffer:4.1.54.Final (c)
|    |    |    +--- io.netty:netty-transport:4.1.54.Final (c)
|    |    |    +--- io.netty:netty-transport-native-epoll:4.1.54.Final (c)
|    |    |    +--- io.netty:netty-transport-native-kqueue:4.1.54.Final (c)
|    |    |    +--- io.netty:netty-handler-proxy:4.1.54.Final (c)
|    |    |    +--- io.netty:netty-codec-http:4.1.54.Final (c)
|    |    |    +--- io.netty:netty-common:4.1.54.Final (c)
|    |    |    +--- io.netty:netty-resolver:4.1.54.Final (c)
|    |    |    +--- io.netty:netty-transport-native-unix-common:4.1.54.Final (c)
|    |    |    +--- io.netty:netty-codec:4.1.54.Final (c)
|    |    |    +--- io.netty:netty-codec-socks:4.1.54.Final (c)
|    |    |    +--- io.netty:netty-handler:4.1.54.Final (c)
|    |    |    \--- io.netty:netty-codec-http2:4.1.54.Final (c)
|    |    |    \--- io.netty:netty-buffer:4.1.54.Final
|    |    |         \--- io.netty:netty-common:4.1.54.Final
|    |    +--- io.netty:netty-codec-http:4.1.54.Final
|    |    |    +--- io.netty:netty-common:4.1.54.Final
|    |    |    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |    |    +--- io.netty:netty-transport:4.1.54.Final
|    |    |    |    +--- io.netty:netty-common:4.1.54.Final
|    |    |    |    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |    |    |    \--- io.netty:netty-resolver:4.1.54.Final
|    |    |    |         \--- io.netty:netty-common:4.1.54.Final
|    |    |    +--- io.netty:netty-codec:4.1.54.Final
|    |    |    |    +--- io.netty:netty-common:4.1.54.Final
|    |    |    |    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |    |    |    \--- io.netty:netty-transport:4.1.54.Final (*)
|    |    |    \--- io.netty:netty-handler:4.1.54.Final
|    |    |         +--- io.netty:netty-common:4.1.54.Final
|    |    |         +--- io.netty:netty-resolver:4.1.54.Final (*)
|    |    |         +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |    |         +--- io.netty:netty-transport:4.1.54.Final (*)
|    |    |         \--- io.netty:netty-codec:4.1.54.Final (*)
|    |    +--- io.netty:netty-handler:4.1.54.Final (*)
|    |    \--- io.netty:netty-codec-http2:4.1.54.Final
|    |         +--- io.netty:netty-common:4.1.54.Final
|    |         +--- io.netty:netty-buffer:4.1.54.Final (*)
|    |         +--- io.netty:netty-transport:4.1.54.Final (*)
|    |         +--- io.netty:netty-codec:4.1.54.Final (*)
|    |         +--- io.netty:netty-handler:4.1.54.Final (*)
|    |         \--- io.netty:netty-codec-http:4.1.54.Final (*)
|    \--- io.netty:netty-handler-proxy:4.1.54.Final
|         +--- io.netty:netty-common:4.1.54.Final
|         +--- io.netty:netty-buffer:4.1.54.Final (*)
|         +--- io.netty:netty-transport:4.1.54.Final (*)
|         +--- io.netty:netty-codec:4.1.54.Final (*)
|         +--- io.netty:netty-codec-socks:4.1.54.Final
|         |    +--- io.netty:netty-common:4.1.54.Final
|         |    +--- io.netty:netty-buffer:4.1.54.Final (*)
|         |    +--- io.netty:netty-transport:4.1.54.Final (*)
|         |    \--- io.netty:netty-codec:4.1.54.Final (*)
|         \--- io.netty:netty-codec-http:4.1.54.Final (*)
+--- io.netty:netty-buffer -> 4.1.54.Final (*)
+--- io.netty:netty-transport -> 4.1.54.Final (*)
+--- io.netty:netty-transport-native-epoll -> 4.1.54.Final
|    +--- io.netty:netty-common:4.1.54.Final
|    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    +--- io.netty:netty-transport:4.1.54.Final (*)
|    \--- io.netty:netty-transport-native-unix-common:4.1.54.Final
|         +--- io.netty:netty-common:4.1.54.Final
|         +--- io.netty:netty-buffer:4.1.54.Final (*)
|         \--- io.netty:netty-transport:4.1.54.Final (*)
+--- io.netty:netty-transport-native-kqueue -> 4.1.54.Final
|    +--- io.netty:netty-common:4.1.54.Final
|    +--- io.netty:netty-buffer:4.1.54.Final (*)
|    +--- io.netty:netty-transport:4.1.54.Final (*)
|    \--- io.netty:netty-transport-native-unix-common:4.1.54.Final (*)
|    \--- io.netty:netty-codec-http:4.1.54.Final (*)

@alvarosanchez alvarosanchez requested a review from ilopmar December 2, 2020 12:52
@ilopmar
Copy link
Contributor

ilopmar commented Dec 2, 2020

I've refreshed it. Running a dependency reports only shows 4.1.54 but I still see 4.1.46 on IntelliJ 🤷‍♂️

@alvarosanchez alvarosanchez merged commit cf0ad63 into master Dec 2, 2020
@alvarosanchez alvarosanchez deleted the issue_134 branch December 2, 2020 15:31
@alvarosanchez alvarosanchez restored the issue_134 branch December 2, 2020 15:44
@alvarosanchez alvarosanchez deleted the issue_134 branch December 2, 2020 15:44
@alvarosanchez alvarosanchez restored the issue_134 branch December 2, 2020 15:44
@alvarosanchez alvarosanchez mentioned this pull request Dec 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilopmar ilopmar ilopmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Netty version once it's updated on core
2 participants
@alvarosanchez @ilopmar