Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mapping empty page #3180

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Fix mapping empty page #3180

merged 3 commits into from
Oct 16, 2024

Conversation

radovanradic
Copy link
Contributor

New issue with Page mapping #3179
Added workaround since empty is special case, there have been number of issues since totalSize is nullable.

@radovanradic
Copy link
Contributor Author

Targetting 4.10.x since there could be release soon and so we don't have to merge from 4.9.x again

@radovanradic radovanradic added the type: bug Something isn't working label Oct 16, 2024
@radovanradic radovanradic linked an issue Oct 16, 2024 that may be closed by this pull request
Page.empty() is still broken #3179
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@radovanradic radovanradic merged commit 379e4e3 into 4.10.x Oct 16, 2024
53 checks passed
@radovanradic radovanradic deleted the page-empty-map branch October 16, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstepanov dstepanov dstepanov approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page.empty() is still broken
2 participants
@radovanradic @dstepanov