Fix query with predication specification and cursored pageable #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radovanradic
commented
Aug 8, 2024
| @@ -53,19 +53,8 @@ public Object intercept(RepositoryMethodKey methodKey, MethodInvocationContext<O | |||
| } | |||
|
|
|||
| Pageable pageable = getPageable(context); | |||
| if (pageable.isUnpaged()) { | |||
There was a problem hiding this comment.
Removing this code because the same is being done below. And the issue was that in the reported issue, pageable.isUnpaged() evaluates to true (initialized only with sort, page size is not set) but expected result was CursoredPage and here Page was immediately returned causing ClassCastException.
|
graemerocher
approved these changes
Aug 8, 2024
dstepanov
approved these changes
Aug 8, 2024
andriy-dmytruk
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3056