Configure histogram flavor/max buckets per meter #5974
Conversation
Adds new configuration methods to override the registry-wide configuration at a per Meter (name) level. This gives more fine-grain control of the configuration.
shakuzen
force-pushed
the
expo-max-per-meter
branch
from
e0b7515 to
5dd7e2c
Compare
| @@ -264,4 +292,14 @@ default TimeUnit baseTimeUnit() { | |||
| return getTimeUnit(this, "baseTimeUnit").orElse(TimeUnit.MILLISECONDS); | |||
| } | |||
|
|
|||
| static <V> Map<String, V> propertiesStringToMap(String propertiesString, | |||
There was a problem hiding this comment.
I don't like that this is a public method. We should probably move it somewhere internal instead.
|
Pinging some folks who expressed interest in or provided input on this feature before to get any feedback they may have on this proposal: @lenin-jaganathan @pirgeo @sfc-gh-rscott @sfc-gh-dguy. Of course anyone else is welcome to give feedback too. In #5459 I expressed a desire to expose the configuration at the |
|
We have the last 1.15 milestone release on Monday, so I'd like to merge something for this in time for that. If anyone has feedback on the proposal, please share. |
Adds new configuration methods to override the registry-wide configuration at a per Meter (name) level. This gives more fine-grain control of the configuration.
The registry-wide HistogramFlavor configuration can be overridden at the meter level with the new
histogramFlavorPerMeterconfiguration method, which returns aMap<String, HistogramFlavor>where the key is the exact Meter name to match.Likewise, the registry-wide max bucket count can be overridden at the meter level with the new
maxBucketsPerMeterconfiguration method, which returns aMap<String, Integer>where the key is the exact Meter name to match.TODO: Update documentation
Closes #5459