Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Schema Registry URL not being defined in default testing properties #323

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Fix Schema Registry URL not being defined in default testing properties #323

merged 1 commit into from
Feb 19, 2025

Conversation

fdelsert
Copy link
Contributor

Issue: #319

@loicgreffier loicgreffier linked an issue Feb 19, 2025 that may be closed by this pull request
KafkaStreamsStarterTest#getProperties should expose schema.registry.url #319
Closed
@loicgreffier loicgreffier added the bug Something isn't working label Feb 19, 2025
loicgreffier
loicgreffier approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@loicgreffier loicgreffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdelsert Thanks for the PR, LGTM

@loicgreffier loicgreffier changed the title Fix KafkaStreamsStarterTest#getProperties did not expose the schema registry url Fix Schema Registry URL not being defined in default testing properties Feb 19, 2025
@loicgreffier loicgreffier merged commit 532e696 into michelin:main Feb 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicgreffier loicgreffier loicgreffier approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KafkaStreamsStarterTest#getProperties should expose schema.registry.url
2 participants
@fdelsert @loicgreffier