Allow ProcessingResult to wrap record with headers #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static <K, V, V2> Record<K, ProcessingResult<V, V2>> wrapRecordSuccess(K key, | ||
| V value, | ||
| long timestamp, | ||
| Headers header) { |
There was a problem hiding this comment.
We should set headers as it is a list
| @@ -106,6 +107,47 @@ public static <K, V, V2> Record<K, ProcessingResult<V, V2>> wrapRecordSuccess(K | |||
| return new Record<>(key, ProcessingResult.success(value), timestamp); | |||
| } | |||
|
|
|||
| /** | |||
| * Wraps a key, value, timestamp and header in a Record with ProcessingResult#success(V value) as value. | |||
There was a problem hiding this comment.
headers instead of header
| } | ||
|
|
||
| /** | ||
| * Wraps a record's value and the header with ProcessingResult.success(V value). |
There was a problem hiding this comment.
headers instead of header
| */ | ||
| public static <K, V, V2> Record<K, ProcessingResult<V, V2>> wrapRecordSuccessWithHeader(Record<K, V> message) { | ||
| return new Record<>( | ||
| message.key(), |
There was a problem hiding this comment.
You have additional tabs here
| @@ -56,6 +61,65 @@ void shouldCreateWrappedProcessingResult() { | |||
| assertEquals(message.timestamp(), wrappedRecord.timestamp()); | |||
| } | |||
|
|
|||
| @Test | |||
| void shouldCreateWrappedProcessingResultWithHeader() { | |||
There was a problem hiding this comment.
shouldCreateWrappedProcessingResultWithHeaderS
| } | ||
|
|
||
| @Test | ||
| void shouldCreateWrappedProcessingResultWithHeaderV2() { |
There was a problem hiding this comment.
shouldWrapRecordSuccessWithHeadersFromParameters would be more convenient and compliant with the previous test
loicgreffier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the issue #313, I updated the code to be able to forward the header in case of success.