Handle wildcard for get and delete commands #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasCAI-mlv
force-pushed
the
feat/wildcard-get
branch
2 times, most recently
from
90a7f41 to
3f681b5
Compare
Signed-off-by: thcai <thomas.cai_ext@michelin.com>
Signed-off-by: thcai <thomas.cai_ext@michelin.com>
Signed-off-by: thcai <thomas.cai_ext@michelin.com>
ThomasCAI-mlv
force-pushed
the
feat/wildcard-get
branch
from
3f681b5 to
8bf5e01
Compare
Signed-off-by: thcai <thomas.cai_ext@michelin.com>
Signed-off-by: thcai <thomas.cai_ext@michelin.com>
There was a problem hiding this comment.
@ThomasCAI-mlv Here is my review:
- Minor updates
- One improvement on the
deletecommand that should be done outside of this PR
loicgreffier
changed the title
Signed-off-by: thcai <thomas.cai_ext@michelin.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.