use latest play services version 21.0.1 #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalchudziak
added a commit
that referenced
this pull request
Aug 29, 2023
* use latest play services version 21.0.1 (#249) Thanks, I'll test this out and include in the next version * work in Headless JS (#254) Co-authored-by: lavrik acer <valery.lavrik@gmail.com> * Default `maximumAge` to 0 on iOS. (#268) * Example updates (#270) * chore: headless js + example updates * chore: revert ts changes * chore: fix background location timer types * chore: move types package --------- Co-authored-by: Brian Rojas <marchinram@gmail.com> Co-authored-by: valery-lavrik <valery-lavrik@users.noreply.github.com> Co-authored-by: lavrik acer <valery.lavrik@gmail.com> Co-authored-by: Justin Kaufman <57186+jkaufman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Google released
play-services-location21.0.1back in 11/2022 so seems like a good time to update, also due to other dependencies requiring21.0.1my project resolves to this version, when I attempt to usereact-native-geolocationwith21.0.1in my app I get the following error:This is actually fixed by updating to
21.0.0however seems better to update to latest.Test Plan
Ran all tests in the
package.jsonscripts section, ran sample app and tested it worked, and tested in my own app where I initially noticed the issue, tested changes by updating@react-native-community/geolocationindependenciesto use local path of git repo for my fork.