Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript broken in 3.2.0 #301

Closed
suman379 opened this issue Feb 29, 2024 · 3 comments · Fixed by #307
Closed

Typescript broken in 3.2.0 #301

suman379 opened this issue Feb 29, 2024 · 3 comments · Fixed by #307
Labels
bug Something isn't working

Comments

@suman379
Copy link

After upgrading to 3.2.0, no typescript suggestion available. Am I missing something?

Versions

  • react-native-geolocation: 3.2.0
  • react-native: 0.72.10
  • react: 18.2.0
@suman379 suman379 added the bug Something isn't working label Feb 29, 2024
@littleski
Copy link

yeah they are

i use a patch in the mean time to change the package.json so it points types to the untranspiled file (js/index.ts) instead of
"types": "lib/typescript/lib/commonjs/index.d.ts",

waiting for the fix too :)

@nicolascavallin
Copy link

+1

@Jorge-Luis-Rangel-Peralta
Copy link

Me too

wneel added a commit to wneel/react-native-geolocation that referenced this issue Mar 26, 2024
@wneel
Update package.json
bdc6030 
fix: michalchudziak#301
@wneel wneel mentioned this issue Mar 26, 2024
Merged
michalchudziak pushed a commit that referenced this issue Mar 28, 2024
@wneel
Update package.json (#307)
74265e7 
fix: #301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TS in 3.2 wneel/react-native-geolocation
4 participants
@littleski @suman379 @nicolascavallin @Jorge-Luis-Rangel-Peralta