This repository has been archived by the owner on Nov 29, 2018. It is now read-only.
Fix Filter decorator with nested key paths of null #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the filter decorator when using nested key paths. If the nested key path value is
null
. The key path one level higher is written. As an example:This prints out:
As you can see, when the value of
a.first
isnull
, the saved data structure is corrupted.This PR ensures that a null or undefined value will properly set the state tree.