Exclude Cypress and Karma from docker images #2309
Conversation
|
Seems to work ! |
| @@ -50,11 +50,23 @@ | |||
| "node": ">=6.9.0", | |||
| "npm": ">=3.10.3" | |||
| }, | |||
| "optionalDependencies": { | |||
| "@bahmutov/add-typescript-to-cypress": "^2.0.0", | |||
There was a problem hiding this comment.
Not sure about that. There's no standard property called optionalDependencies in package.json.
There was a problem hiding this comment.
Is this not standard ? https://docs.npmjs.com/files/package.json#optionaldependencies
There was a problem hiding this comment.
In my opinion the issue with our package.json is that a lot of things that are currently listed as devDependencies are actually needed to build the prod environment as well: gulp, rollup, and types, for example, are needed by the build process.
In this regard, I don't quite see the point of the current split between dependencies and devDependencies. AFAICT there's nowhere we can run npm install --production.
Since I didn't want to bring that issue up, I tried instead to look for something like testDependencies, but the closest I could find was this optionalDepedencies.
To sum up, I currently see two options only:
- move all dependencies required by the prod build to
dependencies - keep change as is
There was a problem hiding this comment.
Ah ok you accepted already :)
* Fix: fakeAsync Karma Test * add resolutions field to package.json (#2302) * add resolutions field to package.json * use npm ci * configure cache directories for ci * chore(package): update rollup to version 0.62.0 (#2304) * chore(package): update yargs to version 12.0.1 (#2306) * Update package-lock.json to fix CI build (#2308) * Typescript Cypress custom commands (#2307) Make it possible to use custom Cypress command in the .ts specs * Exclude Cypress and Karma from docker images (#2309) * Fix: fakeAsync Karma Test
Trying #2290 again on a new branch, because the builds did not seem to be reset properly between commits on the other branch