Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target net6.0 only for unit test #371

Merged
merged 2 commits into from
Jul 17, 2022
Merged

Conversation

vanillajonathan
Copy link
Contributor

@vanillajonathan vanillajonathan commented Jul 15, 2022

We do not need to target both net472 and net6.0 for the unit tests. Not targeting net472 allows the unit test to also run on Linux without Mono installed.

This makes it so you can run the tests without have to have Mono installed.
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #371 (1a28525) into master (07a8058) will not change coverage.
The diff coverage is n/a.

❗ Current head 1a28525 differs from pull request most recent head 01d4ae0. Consider uploading reports for the commit 01d4ae0 to get more accurate results

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files           6        6           
  Lines         839      839           
  Branches       85       85           
=======================================
  Hits          793      793           
  Misses         34       34           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a8058...01d4ae0. Read the comment docs.

@vanillajonathan vanillajonathan changed the title Skip net472 on non-Windows platforms such as Linux Target net6.0 only for unit test Jul 15, 2022
@mganss mganss merged commit 67f021d into mganss:master Jul 17, 2022
@vanillajonathan vanillajonathan deleted the patch-1 branch July 17, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants