Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ICollection instead of IList #361

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

vanillajonathan
Copy link
Contributor

Follow Microsoft's Framework Design Guidelines.

✔️ DO use Collection<T> or a subclass of Collection<T> for properties or return values representing read/write collections.

https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/guidelines-for-collections

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #361 (84d6770) into master (7297a73) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files           4        4           
  Lines         811      811           
  Branches       85       85           
=======================================
  Hits          765      765           
  Misses         34       34           
  Partials       12       12           
Impacted Files Coverage Δ
src/HtmlSanitizer/EventArgs.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7297a73...84d6770. Read the comment docs.

@mganss mganss merged commit 79c4345 into mganss:master Jun 16, 2022
@vanillajonathan vanillajonathan deleted the patch-3 branch June 16, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants