-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update beta calibration docs #2097
Conversation
This reverts commit 3ea6cd6.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2097 +/- ##
==========================================
+ Coverage 98.39% 98.41% +0.01%
==========================================
Files 124 135 +11
Lines 12212 13304 +1092
==========================================
+ Hits 12016 13093 +1077
- Misses 196 211 +15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think outlining how to determine alpha
and beta
values is important element to promote the use/uptake of this CLI.
doc/source/extended_documentation/calibration/beta_recalibration/beta_recalibration.rst
Outdated
Show resolved
Hide resolved
doc/source/extended_documentation/calibration/beta_recalibration/beta_recalibration.rst
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think outlining how to determine alpha
and beta
values is important element to promote the use/uptake of this CLI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked both the local build and the build on read-the-docs. Both appear to work fine, so thanks for this.
|
||
Alternatively, one could jointly optimise the blending weights and the parameters of the beta calibration. This may yield better results, but | ||
is more complex. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional detail.
Follow-up to #2078