Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the docs fix #2093

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Read the docs fix #2093

merged 1 commit into from
Feb 6, 2025

Conversation

bayliffe
Copy link
Contributor

@bayliffe bayliffe commented Feb 5, 2025

Add sphinx config path explicitly to readthedocs yaml file to accommodate recent deprecation, see:
https://about.readthedocs.com/blog/2024/12/deprecate-config-files-without-sphinx-or-mkdocs-config

Testing:
Built the latest docs using this change which can be seen here: https://bens-improver-fork.readthedocs.io/en/latest/

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (84a8944) to head (2eaebc5).
Report is 68 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2093      +/-   ##
==========================================
+ Coverage   98.39%   98.40%   +0.01%     
==========================================
  Files         124      134      +10     
  Lines       12212    13267    +1055     
==========================================
+ Hits        12016    13056    +1040     
- Misses        196      211      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gavinevans gavinevans self-assigned this Feb 5, 2025
Copy link
Contributor

@gavinevans gavinevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bayliffe 👍

This makes sense based on the recent read the docs deprecation.

@gavinevans gavinevans removed their assignment Feb 5, 2025
Copy link
Contributor

@brhooper brhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bayliffe

@brhooper brhooper merged commit f993702 into metoppv:master Feb 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants