Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two new APIs #2091

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Conversation

mo-robertneal
Copy link
Contributor

Adding new APIs for extract_from_table and gradient_between_vertical_levels. Also, adding Robert Neal to the list of repository contributers.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (84a8944) to head (a55914a).
Report is 66 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2091      +/-   ##
==========================================
+ Coverage   98.39%   98.40%   +0.01%     
==========================================
  Files         124      134      +10     
  Lines       12212    13254    +1042     
==========================================
+ Hits        12016    13043    +1027     
- Misses        196      211      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpelley
Copy link
Contributor

cpelley commented Feb 3, 2025

extract_from_table as per

from improver.utilities.extract_from_table import ExtractValueFromTable

gradient_between_vertical_levels as per

from improver.utilities.gradient_between_vertical_levels import (
GradientBetweenVerticalLevels,

Copy link
Contributor

@cpelley cpelley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

In future, ideally the table argument would be migrated to being an initialisation keyword argument (improver/cli/extract_from_table.py).
Also, the improvement of plugin UI to make use of as_cube, as_cubes and as_iterable. Such things facilitate using such plugins and no longer having to consider whether a cubelist or list of cubes or some variation is provided.

@mo-robertneal mo-robertneal merged commit fb9cf53 into metoppv:master Feb 4, 2025
10 checks passed
@mo-robertneal mo-robertneal deleted the add_two_new_APIs branch February 4, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants