More cli refactoring #2075
Merged
More cli refactoring #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 tasks
|
I'll put this up for a science review once I have a review from the systems team |
cpelley
previously approved these changes
Jan 10, 2025
| @@ -36,6 +37,18 @@ def process(self, cubelist: Union[List[Cube], CubeList]) -> Cube: | |||
| Returns: | |||
| Concatenated forecasts | |||
| """ | |||
| if len(cubelist) == 1: | |||
There was a problem hiding this comment.
Not a required change, but I typically would use as_cubelist(cubes) before this and adding *cubes to the args of the function. This makes it a bit more flexible to how one calls and interacts with the plugin.
cpelley
approved these changes
Jan 20, 2025
bayliffe
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More CLI refactoring for simplified implementation of dagrunner
Testing: