MOBT-809: Backport weather symbol release changes into master #2065
+197
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2065 +/- ##
========================================
Coverage 98.39% 98.40%
========================================
Files 124 134 +10
Lines 12212 13158 +946
========================================
+ Hits 12016 12948 +932
- Misses 196 210 +14 ☔ View full report in Codecov by Sentry. |
Kat-90
reviewed
Dec 30, 2024
Kat-90
reviewed
Dec 30, 2024
improver_tests/acceptance/SHA256SUMS
Outdated
| @@ -994,8 +994,9 @@ ea67ae7a7f5363ae3692b29c93fb9989449d96e49dc613a1297d98ddb12c578a ./weather-symb | |||
| 51f636314a6d1fa894ab98cf750493503b191a779c67d6a15081aab2a3612a31 ./weather-symbol-modes/spot_ties/20201209T1700Z-weather_symbols-PT01H.nc | |||
| 134fb1750cf47e868ee67801b1ea5b1f17120e6f58a787a69e54638d7d88ff82 ./weather-symbol-modes/spot_ties/20201209T1800Z-weather_symbols-PT01H.nc | |||
| 391a9bd50824318fb8f147db3b14bcd56f5b0f0e0d5479b3579e08d70ef6ba77 ./weather-symbol-modes/spot_ties/kgo.nc | |||
| 391a9bd50824318fb8f147db3b14bcd56f5b0f0e0d5479b3579e08d70ef6ba77 ./weather-symbol-modes/spot_ties/new_kgo.nc | |||
There was a problem hiding this comment.
Is this new line right? I can't see a "new_kgo" in the original and is it supposed to have the same checksum as the one above?
There was a problem hiding this comment.
Nope, my bad. Removed. I've also rebased this branch and the acceptance test data on the most recent version of master and re-run the acceptance tests to ensure everything works.
…hanges primarily aimed at including the cloud component from wet symbols in dry day symbolderivation.
Kat-90
previously approved these changes
Jan 7, 2025
gavinevans
requested changes
Jan 10, 2025
improver_tests/categorical/decision_tree/test_ModalFromGroupings.py
Outdated
Show resolved
Hide resolved
gavinevans
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport release changes for wx modal derivation into master. These changes primarily aimed at including the cloud component from wet symbols in dry day symbol derivation.
Testing: