Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO: Differences in structure of iso-rice-en and iso-rice-zh #31

Closed
Intelligent2013 opened this issue Nov 30, 2019 · 4 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Nov 30, 2019

There are differences between xml and doc for ISO rice.

  1. In iso-rice-zh.xml there isn't section/preface/introduction, looks like it moved into sections/clause (first clause), i.e. second clause in iso-rice-zh.xml is first clause (Scope) in iso-rice-en.xml.

  2. If compare docs iso-rice-en.doc and iso-rice-zh.doc :

  • in iso-rice-zh.doc section 'Normative references' (7 elements) moved at the end of document as Bibliography (7 elements)
  • in iso-rice-zh.doc there isn't last Bibliography section which contains 16 elements (in iso-rice-en.doc).
    But xml there are such data.
  1. In iso-rice-en.xml the section 'Terms and definitions' placed in terms/term tag, but iso-rice-zh.xml this section placed in clause/clause tag.
    These texts 'paddy', 'husked rice', 'milled rice' display in Contents table (see image), because they are in clause/clause (we show 1st and 2nd level titles from clauses).

Untitled

@Intelligent2013 Intelligent2013 added the invalid This doesn't seem right label Nov 30, 2019
@Intelligent2013 Intelligent2013 changed the title ISO: Differences in structure of iso-rice-en.xml and iso-rice-zh.xml ISO: Differences in structure of iso-rice-en and iso-rice-zh Nov 30, 2019
@ronaldtse ronaldtse added bug Something isn't working and removed invalid This doesn't seem right labels Dec 1, 2019
@ronaldtse
Copy link
Contributor

  1. In the TOC, individual terms should not be TOC entries.

  2. The difference in Normative References and Bibliography are probably errors. Tracking in ISO Rice Chinese marked up differently from English in XML metanorma-iso#299 .

@Intelligent2013
Copy link
Contributor Author

  1. In the TOC, individual terms should not be TOC entries.

I display 1st and 2nd levels of clauses (for example, 4 and 4.1, 4.2) in TOC.
In https://metanorma.github.io/mn-samples-iso/documents/iso-rice-zh.xml, individuals terms placed in clause(s):
image

In https://metanorma.github.io/mn-samples-iso/documents/iso-rice-en.xml, individuals terms places in term(s), so it's correct:
image

@ronaldtse
Copy link
Contributor

@Intelligent2013 thank you for the explanation. I can confirm that the XML generated is incorrect. This will be resolved in metanorma/metanorma-iso#299 .

@opoudjis
Copy link
Contributor

@Intelligent2013 I've fixed these.

Yes I know it's taken a month. I have a large backlog...

@opoudjis opoudjis removed their assignment Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants