preserve Semantic XML in bibitem: https://github.com/metanorma/isodoc… #624

opoudjis · 2025-02-19T09:29:00Z

Metanorma PR checklist

Breaking changes (list related PRs)
Documentation update required (create task for this)
External dependency introduced (documentation update need)
Gem with native library introduced

hound · 2025-02-19T09:29:08Z

spec/isodoc/ref_spec.rb

@@ -600,15 +648,15 @@
      </itu-standard>
    INPUT
    presxml = <<~OUTPUT
-      <itu-standard xmlns="http://riboseinc.com/isoxml" type="presentation">
+       <itu-standard xmlns="http://riboseinc.com/isoxml" type="presentation">


Use 2 spaces for indentation in a heredoc.

hound · 2025-02-25T14:04:13Z

lib/isodoc/itu/presentation_section.rb

+        out.previous = ret
+      end
+
+      def title_footnotes(isoxml)


Inconsistent indentation detected.

hound · 2025-02-25T14:04:13Z

lib/isodoc/itu/presentation_section.rb

+        out.previous = ret
+      end
+
+      def middle_title_recommendation(isoxml, out)


Inconsistent indentation detected.
Assignment Branch Condition size for middle_title_recommendation is too high. [<11, 16, 5> 20.05/15]
Method has too many lines. [11/10]

hound · 2025-02-25T14:04:13Z

lib/isodoc/itu/presentation_section.rb

+        middle_title_resolution_subtitle(isoxml, out)
+      end
+
+      def middle_title_resolution_subtitle(isoxml, out)


Inconsistent indentation detected.

hound · 2025-02-25T14:04:13Z

lib/isodoc/itu/presentation_section.rb

+          end
+      end
+
+      def middle_title_resolution(isoxml, out)


Inconsistent indentation detected.

hound · 2025-02-25T14:04:13Z

lib/isodoc/itu/presentation_section.rb

+      end
+
+      # KILL
+      def renumber_footnotesx(isoxml)


Inconsistent indentation detected.

hound · 2025-02-25T14:04:14Z

lib/isodoc/itu/presentation_section.rb

+
+      def annex1_resolution(elem)
+        elem.elements.first.previous = annex1_supertitle(elem)
+         # TODO: do not alter title, alter semx/@element = title


Incorrect indentation detected (column 9 instead of 8).

hound · 2025-02-25T14:04:14Z

lib/isodoc/itu/presentation_section.rb

+        end
+      end
+
+      def annex1_resolution(elem)


Inconsistent indentation detected.

hound · 2025-02-25T14:04:14Z

lib/isodoc/itu/presentation_section.rb

+          !%w(sections bibliography).include?(elem.parent.name)
+      end
+
+      def annex1(elem)


Inconsistent indentation detected.

hound · 2025-02-25T14:04:14Z

lib/isodoc/itu/presentation_section.rb

+          #"<span element='fmt-element-name'>#{@i18n.get['section'].upcase}</span> #{autonum(elem['id'], lbl)}</p>"
+      end
+
+      def clause1_super?(elem)


Inconsistent indentation detected.

hound · 2025-02-25T14:04:14Z

lib/isodoc/itu/presentation_section.rb

+          "<p keep-with-next='true' class='supertitle'>" \
+          "#{labelled_autonum(@i18n.get['section'].upcase, elem["id"], lbl)}</p>"
+          #"<span element='fmt-element-name'>#{@i18n.get['section'].upcase}</span> #{autonum(elem['id'], lbl)}</p>"
+      end


end at 16, 6 is not aligned with def at 4, 12.

lib/isodoc/itu/presentation_section.rb

hound · 2025-02-26T13:49:17Z

lib/isodoc/itu/presentation_section.rb

+        elem.previous =
+          "<p keep-with-next='true' class='supertitle'>" \
+          "#{labelled_autonum(@i18n.get['section'].upcase, elem["id"], lbl)}</p>"
+          #"<span element='fmt-element-name'>#{@i18n.get['section'].upcase}</span> #{autonum(elem['id'], lbl)}</p>"


Incorrect indentation detected (column 10 instead of 8).
Missing space after #.
Line is too long. [115/80]

hound · 2025-02-26T13:49:17Z

lib/isodoc/itu/presentation_section.rb

+        lbl.blank? || elem["unnumbered"] and return
+        elem.previous =
+          "<p keep-with-next='true' class='supertitle'>" \
+          "#{labelled_autonum(@i18n.get['section'].upcase, elem["id"], lbl)}</p>"


Prefer single-quoted strings inside interpolations.
Line is too long. [81/80]

hound · 2025-02-26T13:49:17Z

lib/isodoc/itu/presentation_section.rb

+  module Itu
+    class PresentationXMLConvert < IsoDoc::PresentationXMLConvert
+            def clause1(elem)
+        clause1_super?(elem) and return super


Use 2 (not -4) spaces for indentation.

hound · 2025-02-26T13:49:17Z

lib/isodoc/itu/presentation_section.rb

+module IsoDoc
+  module Itu
+    class PresentationXMLConvert < IsoDoc::PresentationXMLConvert
+            def clause1(elem)


Use 2 (not 8) spaces for indentation.

hound · 2025-02-26T13:49:17Z

lib/isodoc/itu/presentation_xml_convert.rb

+          "<sup>#{fn_label(fnote)}" \
+            "<span class='fmt-label-delim'>)</span></sup>"
+        end
+      end


end at 119, 6 is not aligned with def at 111, 7.

hound · 2025-02-26T13:49:18Z

spec/isodoc/blocks_spec.rb

+      .gsub(%r{^.*<body}m, "<body")
+      .gsub(%r{</body>.*}m, "</body>")
+      .gsub(/mso-bookmark:_Ref\d+/, "mso-bookmark:_Ref"))))
+      .to be_equivalent_to Xml::C14n.format(word)


Use 2 (not 1) spaces for indenting an expression spanning multiple lines.

hound · 2025-02-26T13:49:18Z

spec/isodoc/blocks_spec.rb

+    expect(Xml::C14n.format(strip_guid(IsoDoc::Itu::HtmlConvert.new({})
+      .convert("test", pres_output, true))))
+      .to be_equivalent_to Xml::C14n.format(html)
+     expect(Xml::C14n.format(strip_guid(IsoDoc::Itu::WordConvert.new({})


Inconsistent indentation detected.

hound · 2025-02-26T13:49:18Z

spec/isodoc/blocks_spec.rb

-    expect(Xml::C14n.format(IsoDoc::Itu::WordConvert.new({})
+
+    word = <<~OUTPUT
+       <body lang="EN-US" link="blue" vlink="#954F72">


Use 2 spaces for indentation in a heredoc.

hound · 2025-02-26T13:49:18Z

spec/isodoc/blocks_spec.rb

+       </iso-standard>
+    OUTPUT
+    html = <<~OUTPUT
+          <html lang="en">


Use 2 spaces for indentation in a heredoc.

hound · 2025-02-26T13:49:18Z

spec/isodoc/ituconvert_spec.rb

-           </tfoot>
-        </table>
-      OUTPUT
+      .to be_equivalent_to Xml::C14n.format(output)


Use 2 (not 0) spaces for indenting an expression spanning multiple lines.

…c#968

hound · 2025-02-27T15:25:49Z

spec/isodoc/ituconvert_spec.rb

+          </tfoot>
+       </table>
+      OUTPUT
+      expect(Xml::C14n.format(html


Inconsistent indentation detected.

hound · 2025-02-27T15:25:49Z

spec/isodoc/ituconvert_spec.rb

+             </tr>
+          </tfoot>
+       </table>
+      OUTPUT


OUTPUT is not aligned with output = <<~OUTPUT.

hound · 2025-02-27T15:25:49Z

spec/isodoc/ituconvert_spec.rb


    FileUtils.rm_f "test.doc"
    IsoDoc::Itu::WordConvert.new({}).convert("test", pres_output, false)
    expect(File.exist?("test.doc")).to be true
    html = File.read("test.doc", encoding: "UTF-8")
-    expect(Xml::C14n.format(html
+    output = <<~OUTPUT
+       <table class="MsoISOTable" style="mso-table-anchor-horizontal:column;mso-table-overlap:never;border-spacing:0;border-width:1px;" title="tool tip" summary="long desc">


Use 2 spaces for indentation in a heredoc.

hound · 2025-02-27T15:25:50Z

spec/isodoc/ituconvert_spec.rb

+             <a href="#fnref:5">↩</a>
+          </aside>
+       </main>
+      OUTPUT


OUTPUT is not aligned with output = <<~OUTPUT.

hound · 2025-02-27T15:25:50Z

spec/isodoc/ituconvert_spec.rb

@@ -575,188 +698,180 @@
    IsoDoc::Itu::HtmlConvert.new({}).convert("test", pres_output, false)
    expect(File.exist?("test.html")).to be true
    html = File.read("test.html", encoding: "UTF-8")
+    output = <<~OUTPUT
+       <main xmlns:epub="epub" class="main-section">


Use 2 spaces for indentation in a heredoc.

hound · 2025-02-27T15:25:50Z

spec/isodoc/ituconvert_spec.rb

@@ -468,7 +474,7 @@
          </itu-standard>
    INPUT
    presxml = <<~PRESXML
-      <itu-standard xmlns="http://riboseinc.com/isoxml" type="presentation">
+       <itu-standard xmlns="http://riboseinc.com/isoxml" type="presentation">


Use 2 spaces for indentation in a heredoc.

hound · 2025-02-27T15:25:50Z

spec/isodoc/section_spec.rb

-                 <p class="TableFootnote"><a name="_8a4ff03f-e7a6-4430-939d-1b7b0ffa60e9" id="_8a4ff03f-e7a6-4430-939d-1b7b0ffa60e9"></a><span><span class="TableFootnoteRef"><a name="_5c4d4e85-b6b0-4f34-b1ed-57d28c4e88d4a)" id="_5c4d4e85-b6b0-4f34-b1ed-57d28c4e88d4a)"></a>a)</span><span style="mso-tab-count:1">&#xA0; </span></span>To access the Recommendation, type the URL <a href="http://handle.itu.int/" class="url">http://handle.itu.int/</a> in the address field of your web browser, followed by the Recommendation?~@~Ys unique ID. For example, <a href="http://handle.itu.int/11.1002/1000/11830-en" class="url">http://handle.itu.int/11.1002/1000/11830-en</a></p>
-               </div></div></td></tr></tfoot></table>
-               </div></div>
+       <div>


Use 2 spaces for indentation in a heredoc.

…ing or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

hound · 2025-03-06T00:43:29Z

spec/isodoc/ituconvert_spec.rb

-             <p>Normal footnote</p>
-           </aside>
-         </div>
+       <body xmlns:epub="epub" lang="EN-US" link="blue" vlink="#954F72">


Use 2 spaces for indentation in a heredoc.

preserve Semantic XML in bibitem: metanorma/isodoc#610

f6e61da

opoudjis self-assigned this Feb 19, 2025

hound bot reviewed Feb 19, 2025

View reviewed changes

Presentation XML refactor, footnotes: metanorma/isodoc#623

65b490f

hound bot reviewed Feb 25, 2025

View reviewed changes

github-advanced-security bot found potential problems Feb 25, 2025

View reviewed changes

lib/isodoc/itu/presentation_section.rb Fixed Show fixed Hide fixed

Presentation XML refactor, footnotes: metanorma/isodoc#623

93576c6

hound bot reviewed Feb 26, 2025

View reviewed changes

ensure proper encoding of title footnotes: metanorma/metanorma-stando…

7a5a354

…c#968

hound bot reviewed Feb 27, 2025

View reviewed changes

opoudjis and others added 5 commits February 28, 2025 20:48

rspec

b458061

Potential fix for code scanning alert no. 21: Incomplete string escap…

88915fd

…ing or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

grammars

34a28c5

Merge branch 'main' into fix/bibitem-footnote-presxml

2667f93

rspec

631bc5b

hound bot reviewed Mar 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

preserve Semantic XML in bibitem: https://github.com/metanorma/isodoc… #624

preserve Semantic XML in bibitem: https://github.com/metanorma/isodoc… #624

opoudjis commented Feb 19, 2025

hound bot Feb 19, 2025

hound bot Feb 25, 2025

hound bot Feb 25, 2025

hound bot Feb 25, 2025

hound bot Feb 25, 2025

hound bot Feb 25, 2025

hound bot Feb 25, 2025

hound bot Feb 25, 2025

hound bot Feb 25, 2025

hound bot Feb 25, 2025

hound bot Feb 25, 2025

hound bot Feb 26, 2025

hound bot Feb 26, 2025

hound bot Feb 26, 2025

hound bot Feb 26, 2025

hound bot Feb 26, 2025

hound bot Feb 26, 2025

hound bot Feb 26, 2025

hound bot Feb 26, 2025

hound bot Feb 26, 2025

hound bot Feb 26, 2025

hound bot Feb 27, 2025

hound bot Feb 27, 2025

hound bot Feb 27, 2025

hound bot Feb 27, 2025

hound bot Feb 27, 2025

hound bot Feb 27, 2025

hound bot Feb 27, 2025

hound bot Mar 6, 2025

preserve Semantic XML in bibitem: https://github.com/metanorma/isodoc… #624

Are you sure you want to change the base?

preserve Semantic XML in bibitem: https://github.com/metanorma/isodoc… #624

Conversation

opoudjis commented Feb 19, 2025

Metanorma PR checklist

hound bot Feb 19, 2025

Choose a reason for hiding this comment

hound bot Feb 25, 2025

Choose a reason for hiding this comment

hound bot Feb 25, 2025

Choose a reason for hiding this comment

hound bot Feb 25, 2025

Choose a reason for hiding this comment

hound bot Feb 25, 2025

Choose a reason for hiding this comment

hound bot Feb 25, 2025

Choose a reason for hiding this comment

hound bot Feb 25, 2025

Choose a reason for hiding this comment

hound bot Feb 25, 2025

Choose a reason for hiding this comment

hound bot Feb 25, 2025

Choose a reason for hiding this comment

hound bot Feb 25, 2025

Choose a reason for hiding this comment

hound bot Feb 25, 2025

Choose a reason for hiding this comment

hound bot Feb 26, 2025

Choose a reason for hiding this comment

hound bot Feb 26, 2025

Choose a reason for hiding this comment

hound bot Feb 26, 2025

Choose a reason for hiding this comment

hound bot Feb 26, 2025

Choose a reason for hiding this comment

hound bot Feb 26, 2025

Choose a reason for hiding this comment

hound bot Feb 26, 2025

Choose a reason for hiding this comment

hound bot Feb 26, 2025

Choose a reason for hiding this comment

hound bot Feb 26, 2025

Choose a reason for hiding this comment

hound bot Feb 26, 2025

Choose a reason for hiding this comment

hound bot Feb 26, 2025

Choose a reason for hiding this comment

hound bot Feb 27, 2025

Choose a reason for hiding this comment

hound bot Feb 27, 2025

Choose a reason for hiding this comment

hound bot Feb 27, 2025

Choose a reason for hiding this comment

hound bot Feb 27, 2025

Choose a reason for hiding this comment

hound bot Feb 27, 2025

Choose a reason for hiding this comment

hound bot Feb 27, 2025

Choose a reason for hiding this comment

hound bot Feb 27, 2025

Choose a reason for hiding this comment

hound bot Mar 6, 2025

Choose a reason for hiding this comment