Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename date function #12

Closed
opoudjis opened this issue Feb 13, 2025 · 3 comments
Closed

Rename date function #12

opoudjis opened this issue Feb 13, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@opoudjis
Copy link
Contributor

date function overlaps with the date label that is used in ISO, and results in clashing. Need to (a) rename the function (it's just less disruptive to), and (b) preemptively stop labels from being reassigned as methods, and crash isodoc-i18n, if there is such a clash, it indicates poor input.

@opoudjis opoudjis self-assigned this Feb 13, 2025
@opoudjis opoudjis added the bug Something isn't working label Feb 13, 2025
@ronaldtse
Copy link
Contributor

What's a "date" label? How is it different from the "date" command?

@opoudjis
Copy link
Contributor Author

opoudjis commented Feb 13, 2025

Date is the string "date", internationalised. It is different from the function, and it is a bug that they are aliased.

There is no need to abort, I just need to not assign labels as function aliases, when there is a conflicting function already in place. I am allowing @i18n.terms_and_definitions as an alias of @i18n.labels["terms_and_definitions"], and I simply don't create @i18n.date as an alias of @i18n.labels["date"], because @i18n.date() is already defined.

@opoudjis
Copy link
Contributor Author

Confirmed with date:[] document in ISO, where the clash arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants