-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plateau: ordered list in PDF being rendered differently in viewer #41
Comments
Plateau follows JIS list item labeling. The PDF is correct here. |
thanks @ronaldtse; additionally this main issue also occurs in the viewer version of Plateau doc01 (sources/001-v5) |
The issue is programmatic so both documents will exhibit the same behavior. I believe the best way to handle is have the list label progression definition embedded in the XML source as presentational elements. Ping @opoudjis |
Ping @opoudjis to ensure that list labels are included inside MN XML. |
They already are.
generates in Presentation XML:
Note the |
@opoudjis there is |
As metanorma/metanorma-iso#319 https://github.com/metanorma/metanorma-iso/blob/main/lib/isodoc/iso/html/style-iso.scss will show, changing the rendering in HTML of a ordered list label is convoluted. The only way this is going to be realisable at all is by providing a separate value for the rendering template: the label needs to be kept alone as a value, which would be the input into any CSS counter, and then styled by the template:
The CSS would need to be I will add a label-template attribute to ol/li, which by default will be "%." and in this instance will be "%)". |
Thanks @opoudjis. An additional question: would it be better if we can declare the list styling definitions governing the entire document, and referring to them with names? |
Numbering should be fixed after next deployment. However, the spacing may take longer to update, and I am not sure it will be done by Feb 28. I believe that belongs to another issue. There is a range of choices made by Firelight about line height, etc. that are more about typography and not so much about content. Some of those choices may conflict with JIS. (I accept that list numbering is about content, but note that ideally we could probably use cross-references instead of authors simply typing “a.” and “b.” like in this screenshot — cc @ronaldtse? It would be cumbersome with AsciiDoc, but more easy with a visual editor if it’s implemented.) Note that MN PDF has spacing issues where characters in a list are not grid-aligned with preceding paragraphs (yellow lines on screenshot below). However, Firelight has another spacing issue where characters become misaligned after using “a.” and “b.” in third list item (green lines on screenshot below), I suspect this could be because Firelight is not using half-width or full-width romaji. Instead of relying on the lines you can observe character bounding box grid alignment/misalignment by selecting text in PDF and in Firelight. |
thanks for checking and updating this discussion @strogonoff i can clarify a bit, and after recent discussions with @ronaldtse about how the "dynamic delivery" of the viewer app works. the issue is not the line or character spacing, the main issue was: an ordered list in the PDF is a, b, c... but in the viewer the ordered list was 1, 2, 3... this creates a navigation problem. this is what the issue is about. not line or character spacing. at this time, the main worry is not the spacing issues. if the viewer is fixed to show a. b. c. that is still close enough as the PDF's a), b), c) of course one may ask why the viewer cannot show ")" instead of "." but it could be explained a pending issues with list symbology. hope this clarifies things. let me know if there are any questions. thank you. |
Sure. I’ll investigate showing |
FYI @opoudjis is working on providing the definitions of the label formatting in the XML for renderers. Hopefully that will save time here and prevent double efforts. |
hello @strogonoff please provide an update on this issue. thank you. |
No updates. I believe the concern with wrong numbering (1/2/3 instead of a/b/c) was addressed two weeks ago. |
thank you @strogonoff i see that now and confirm that the numbered list (from the first example) has been fixed. is this issue kept open because of another problem? |
I still want to try a)/b)/c) with parentheses. It may be visible in supported browsers after the next build. But the original issue is probably solved now… |
in Plateau doc02 (sources/002-v5) an ordered list in the PDF is rendering as a) b) c) is being rendered in the viewer as 1) 2) 3)
correctly ordered list from the PDF
the same ordered list in the viewer
The text was updated successfully, but these errors were encountered: