Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build errors:
MSYS builds throw a bunch of redefinition errors in the cairo dwrite code. Not sure why this doesn't happen when building cairo directly. Worked around with
cairo:dwrite=disabled
.MSYS builds fail on:
pango provides a valid
sysprof.wrap
that it doesn't use by default, but this causes glib to autodetect sysprof and fall back to the wrap. In turn, libsysprof tries to useendian.h
, which doesn't exist on Windows. We don't see this in glib builds because glib's ownsysprof.wrap
doesn't list any provides and so is ignored.Worked around with
glib:sysprof=disabled
.MSVC clang-cl fails on this:
Looks like this bug: Clang-cl generates a call to an undefined symbol __udivti3 llvm/llvm-project#25679
Not sure why cairo builds don't see this, and there's no evident workaround.