-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix many things have have been slightly broken in OSX #2618
Conversation
e2407ed
to
3cb7205
Compare
I tested this with a simple setup:
And running
I end up with
with
Note that the binary works as long as So basically this doesn't seem to work for me. (I would also like to occasionally keep the liberty to keep using absolute paths, but that's a lower priority. Current solution would also not work on 10.4, but well ...) |
Can you try writing the same in CMake and trying it out? It would be interesting to know if and how they do it. Thanks. |
I need some more time to figure out what's the proper |
Thanks. I'll merge this now because it improves things and does not seem to regress anything. We can fix the other issues in other MRs. |
Basically this steals even more stuff from CMake's implementation:
Still needs to be added: