Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: Add system libs used by rust std to staticlib external deps #11790

Merged
merged 2 commits into from
May 20, 2023
Merged

rust: Add system libs used by rust std to staticlib external deps #11790

merged 2 commits into from
May 20, 2023

Conversation

xclaesse
Copy link
Member

No description provided.

@xclaesse xclaesse requested review from dcbaker and jpakkane as code owners May 16, 2023 15:13
@xclaesse xclaesse force-pushed the rust-native-static-libs branch 2 times, most recently from 5134675 to c870155 Compare May 16, 2023 15:23
sdroege
sdroege approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for working on this :)

@xclaesse xclaesse mentioned this pull request May 16, 2023
Open
@xclaesse xclaesse force-pushed the rust-native-static-libs branch 2 times, most recently from 70645a4 to f563391 Compare May 16, 2023 16:47
@sdroege
Copy link
Contributor

sdroege commented May 16, 2023

@xclaesse This would link in unnecessarily many libraries in no_std Rust crates. But as those don't compile at all with meson currently due to other problems, this might be OK and should just get a FIXME comment.

@xclaesse xclaesse force-pushed the rust-native-static-libs branch from f563391 to 440e813 Compare May 16, 2023 18:38
@xclaesse xclaesse force-pushed the rust-native-static-libs branch from 440e813 to 9ae58ca Compare May 17, 2023 14:39
@xclaesse xclaesse merged commit c6db870 into mesonbuild:master May 20, 2023
@xclaesse xclaesse deleted the rust-native-static-libs branch May 20, 2023 14:35
@eli-schwartz eli-schwartz mentioned this pull request Oct 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eli-schwartz eli-schwartz eli-schwartz left review comments

@sdroege sdroege sdroege approved these changes

@dcbaker dcbaker Awaiting requested review from dcbaker dcbaker is a code owner

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xclaesse @sdroege @eli-schwartz