[PLAT-71] Allow define one optional volume #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some cases and workloads we need to pass some modules to the task
definition. The volumes are passed as a list of maps to the
ecs_task_resource[1].
But the current syntax of terraform does not allow consume this value
directly from a variable. Trying to do so, we hit the issues described
in [2] and [3] (pending to report a specific bug).
But we found out that it works if we build the map structure directly
within the resource, and we use interpolation to consume the values of
the map.
Meanwhile the terraform project does not provide a definitive solution,
we will implement the following workaround:
- The module will receive configuration for one unique module, being
the default a empty map {}
- If the map is empty, a dummy volume will be passed as `name=dummy`
and `host_path=/tmp/dummy_volume`
This would cover our specific case in the short term, and can be later
easily adapted to use a optional list of volumes.
[1] https://www.terraform.io/docs/providers/aws/r/ecs_task_definition.html#volume
[2] hashicorp/terraform#10407
[3] hashicorp/terraform#7705 (comment)
bart613
approved these changes
May 25, 2017
| "host_path"= "/tmp" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Is this being defined here and in variables.tf on purpose? Would this not cause error?
| ] | ||
| } | ||
|
|
||
| output volumes { |
There was a problem hiding this comment.
Is there a useful, potential reason for this output?
There was a problem hiding this comment.
Sorry, I accidentally added those.
|
Closing it to remove spurious variable and output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some cases and workloads we need to pass some modules to the task definition. The volumes are passed as a list of maps to the
ecs_task_resource[1].But the current syntax of terraform does not allow consume this value directly from a variable. Trying to do so, we hit the issues described in [2] and [3] (pending to report a specific bug).
But we found out that it works if we build the map structure directly within the resource, and we use interpolation to consume the values of the map.
Meanwhile the terraform project does not provide a definitive solution, we
will implement the following workaround:
name=dummyandhost_path=/tmp/dummy_volumeThis would cover our specific case in the short term, and can be later easily adapted to use a optional list of volumes.
[1] https://www.terraform.io/docs/providers/aws/r/ecs_task_definition.html#volume
[2] hashicorp/terraform#10407
[3] hashicorp/terraform#7705 (comment)