Skip to content
This repository was archived by the owner on Feb 11, 2025. It is now read-only.

Add zstd support #197

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Add zstd support #197

merged 1 commit into from
Mar 28, 2022

Conversation

MmAaXx500
Copy link
Contributor

Fixes #156

Proposed Changes

  • Add zstd as supported compression algorithm

Description

This PR introduces zstd compression algorithm with configurable compression level.

I had to pin the klauspost/compress lib to v1.13.5 because go mod tidy complains about missing io/fs and testing/fstest (see) which only supported on go 1.16+ (we are on 1.14 currently)

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).
  • Ensure documentation is up-to-date. The same file will be updated in plugin index when your PR is accepted, so it will be available for end-users at http://plugins.drone.io.

Copy link
Contributor

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇 🚀

@kakkoyun
Copy link
Contributor

kakkoyun commented Mar 9, 2022

I don't see any reasons not to merge it @jimsheldon

@hikerspath hikerspath merged commit fbfdae0 into meltwater:master Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support zstd compression
3 participants