Skip to content
This repository was archived by the owner on Oct 30, 2022. It is now read-only.

Update README #2

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Update README #2

merged 1 commit into from
Feb 16, 2020

Conversation

carolstran
Copy link
Contributor

@carolstran carolstran commented Feb 14, 2020 •
edited
Loading

Added a description and some usage instructions for this package.

My main questions now are...

  • Is there a way to change the default for the runner?
  • Do you think I should add more context on Unmock to this README in case someone stumbles across it first?

Related to meeshkan/unmock-js#299

@carolstran carolstran mentioned this pull request Feb 14, 2020
Open
ksaaskil
ksaaskil approved these changes Feb 15, 2020
View reviewed changes
Copy link

@ksaaskil ksaaskil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sufficient to me as it makes it quite clear one should look into Unmock runner to understand how to use this!

@carolstran carolstran merged commit a5f613a into master Feb 16, 2020
@carolstran carolstran deleted the new-readme branch February 16, 2020 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ksaaskil ksaaskil ksaaskil approved these changes

@mikesol mikesol Awaiting requested review from mikesol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carolstran @ksaaskil