Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(product): Improve product normalization and fix http router with tracing #11724

Merged
merged 11 commits into from
Mar 5, 2025

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Mar 4, 2025

What

  • Improve product normalization and prevent over fetching data
  • Fix HTTP router wrap handler with tracing enabled

Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:50am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:50am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 0:50am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 0:50am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 0:50am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 0:50am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 0:50am
user-guide ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 0:50am

Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 837be10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@medusajs/product Patch
@medusajs/framework Patch
@medusajs/medusa Patch
integration-tests-http Patch
@medusajs/test-utils Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch
@medusajs/telemetry Patch
@medusajs/admin-bundler Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/dashboard Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review March 4, 2025 21:42
@adrien2p adrien2p requested a review from a team as a code owner March 4, 2025 21:42
@adrien2p
Copy link
Member Author

adrien2p commented Mar 4, 2025

/snapshot-this

Copy link
Contributor

github-actions bot commented Mar 4, 2025

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-bundler@2.6.1-snapshot-20250304214849
yarn add @medusajs/admin-sdk@2.6.1-snapshot-20250304214849
yarn add @medusajs/admin-shared@2.6.1-snapshot-20250304214849
yarn add @medusajs/admin-vite-plugin@2.6.1-snapshot-20250304214849
yarn add @medusajs/dashboard@2.6.1-snapshot-20250304214849
yarn add create-medusa-app@2.6.1-snapshot-20250304214849
yarn add @medusajs/cli@2.6.1-snapshot-20250304214849
yarn add medusa-dev-cli@2.6.1-snapshot-20250304214849
yarn add @medusajs/medusa-oas-cli@2.6.1-snapshot-20250304214849
yarn add @medusajs/core-flows@2.6.1-snapshot-20250304214849
yarn add @medusajs/framework@2.6.1-snapshot-20250304214849
yarn add @medusajs/js-sdk@2.6.1-snapshot-20250304214849
yarn add @medusajs/modules-sdk@2.6.1-snapshot-20250304214849
yarn add @medusajs/orchestration@2.6.1-snapshot-20250304214849
yarn add @medusajs/types@2.6.1-snapshot-20250304214849
yarn add @medusajs/utils@2.6.1-snapshot-20250304214849
yarn add @medusajs/workflows-sdk@2.6.1-snapshot-20250304214849
yarn add @medusajs/icons@2.6.1-snapshot-20250304214849
yarn add @medusajs/ui-preset@2.6.1-snapshot-20250304214849
yarn add @medusajs/medusa@2.6.1-snapshot-20250304214849
yarn add @medusajs/telemetry@2.6.1-snapshot-20250304214849
yarn add @medusajs/test-utils@2.6.1-snapshot-20250304214849
yarn add @medusajs/api-key@2.6.1-snapshot-20250304214849
yarn add @medusajs/auth@2.6.1-snapshot-20250304214849
yarn add @medusajs/cache-inmemory@2.6.1-snapshot-20250304214849
yarn add @medusajs/cache-redis@2.6.1-snapshot-20250304214849
yarn add @medusajs/cart@2.6.1-snapshot-20250304214849
yarn add @medusajs/currency@2.6.1-snapshot-20250304214849
yarn add @medusajs/customer@2.6.1-snapshot-20250304214849
yarn add @medusajs/event-bus-local@2.6.1-snapshot-20250304214849
yarn add @medusajs/event-bus-redis@2.6.1-snapshot-20250304214849
yarn add @medusajs/file@2.6.1-snapshot-20250304214849
yarn add @medusajs/fulfillment@2.6.1-snapshot-20250304214849
yarn add @medusajs/index@2.6.1-snapshot-20250304214849
yarn add @medusajs/inventory@2.6.1-snapshot-20250304214849
yarn add @medusajs/link-modules@2.6.1-snapshot-20250304214849
yarn add @medusajs/locking@2.6.1-snapshot-20250304214849
yarn add @medusajs/notification@2.6.1-snapshot-20250304214849
yarn add @medusajs/order@2.6.1-snapshot-20250304214849
yarn add @medusajs/payment@2.6.1-snapshot-20250304214849
yarn add @medusajs/pricing@2.6.1-snapshot-20250304214849
yarn add @medusajs/product@2.6.1-snapshot-20250304214849
yarn add @medusajs/promotion@2.6.1-snapshot-20250304214849
yarn add @medusajs/auth-emailpass@2.6.1-snapshot-20250304214849
yarn add @medusajs/auth-github@2.6.1-snapshot-20250304214849
yarn add @medusajs/auth-google@2.6.1-snapshot-20250304214849
yarn add @medusajs/file-local@2.6.1-snapshot-20250304214849
yarn add @medusajs/file-s3@2.6.1-snapshot-20250304214849
yarn add @medusajs/fulfillment-manual@2.6.1-snapshot-20250304214849
yarn add @medusajs/locking-postgres@2.6.1-snapshot-20250304214849
yarn add @medusajs/locking-redis@2.6.1-snapshot-20250304214849
yarn add @medusajs/notification-local@2.6.1-snapshot-20250304214849
yarn add @medusajs/notification-sendgrid@2.6.1-snapshot-20250304214849
yarn add @medusajs/payment-stripe@2.6.1-snapshot-20250304214849
yarn add @medusajs/region@2.6.1-snapshot-20250304214849
yarn add @medusajs/sales-channel@2.6.1-snapshot-20250304214849
yarn add @medusajs/stock-location@2.6.1-snapshot-20250304214849
yarn add @medusajs/store@2.6.1-snapshot-20250304214849
yarn add @medusajs/tax@2.6.1-snapshot-20250304214849
yarn add @medusajs/user@2.6.1-snapshot-20250304214849
yarn add @medusajs/workflow-engine-inmemory@2.6.1-snapshot-20250304214849
yarn add @medusajs/workflow-engine-redis@2.6.1-snapshot-20250304214849

Latest commit: af613bb

@adrien2p
Copy link
Member Author

adrien2p commented Mar 4, 2025

/snapshot-this

Copy link
Contributor

github-actions bot commented Mar 4, 2025

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-bundler@2.6.1-snapshot-20250304221555
yarn add @medusajs/admin-sdk@2.6.1-snapshot-20250304221555
yarn add @medusajs/admin-shared@2.6.1-snapshot-20250304221555
yarn add @medusajs/admin-vite-plugin@2.6.1-snapshot-20250304221555
yarn add @medusajs/dashboard@2.6.1-snapshot-20250304221555
yarn add create-medusa-app@2.6.1-snapshot-20250304221555
yarn add @medusajs/cli@2.6.1-snapshot-20250304221555
yarn add medusa-dev-cli@2.6.1-snapshot-20250304221555
yarn add @medusajs/medusa-oas-cli@2.6.1-snapshot-20250304221555
yarn add @medusajs/core-flows@2.6.1-snapshot-20250304221555
yarn add @medusajs/framework@2.6.1-snapshot-20250304221555
yarn add @medusajs/js-sdk@2.6.1-snapshot-20250304221555
yarn add @medusajs/modules-sdk@2.6.1-snapshot-20250304221555
yarn add @medusajs/orchestration@2.6.1-snapshot-20250304221555
yarn add @medusajs/types@2.6.1-snapshot-20250304221555
yarn add @medusajs/utils@2.6.1-snapshot-20250304221555
yarn add @medusajs/workflows-sdk@2.6.1-snapshot-20250304221555
yarn add @medusajs/icons@2.6.1-snapshot-20250304221555
yarn add @medusajs/ui-preset@2.6.1-snapshot-20250304221555
yarn add @medusajs/medusa@2.6.1-snapshot-20250304221555
yarn add @medusajs/telemetry@2.6.1-snapshot-20250304221555
yarn add @medusajs/test-utils@2.6.1-snapshot-20250304221555
yarn add @medusajs/api-key@2.6.1-snapshot-20250304221555
yarn add @medusajs/auth@2.6.1-snapshot-20250304221555
yarn add @medusajs/cache-inmemory@2.6.1-snapshot-20250304221555
yarn add @medusajs/cache-redis@2.6.1-snapshot-20250304221555
yarn add @medusajs/cart@2.6.1-snapshot-20250304221555
yarn add @medusajs/currency@2.6.1-snapshot-20250304221555
yarn add @medusajs/customer@2.6.1-snapshot-20250304221555
yarn add @medusajs/event-bus-local@2.6.1-snapshot-20250304221555
yarn add @medusajs/event-bus-redis@2.6.1-snapshot-20250304221555
yarn add @medusajs/file@2.6.1-snapshot-20250304221555
yarn add @medusajs/fulfillment@2.6.1-snapshot-20250304221555
yarn add @medusajs/index@2.6.1-snapshot-20250304221555
yarn add @medusajs/inventory@2.6.1-snapshot-20250304221555
yarn add @medusajs/link-modules@2.6.1-snapshot-20250304221555
yarn add @medusajs/locking@2.6.1-snapshot-20250304221555
yarn add @medusajs/notification@2.6.1-snapshot-20250304221555
yarn add @medusajs/order@2.6.1-snapshot-20250304221555
yarn add @medusajs/payment@2.6.1-snapshot-20250304221555
yarn add @medusajs/pricing@2.6.1-snapshot-20250304221555
yarn add @medusajs/product@2.6.1-snapshot-20250304221555
yarn add @medusajs/promotion@2.6.1-snapshot-20250304221555
yarn add @medusajs/auth-emailpass@2.6.1-snapshot-20250304221555
yarn add @medusajs/auth-github@2.6.1-snapshot-20250304221555
yarn add @medusajs/auth-google@2.6.1-snapshot-20250304221555
yarn add @medusajs/file-local@2.6.1-snapshot-20250304221555
yarn add @medusajs/file-s3@2.6.1-snapshot-20250304221555
yarn add @medusajs/fulfillment-manual@2.6.1-snapshot-20250304221555
yarn add @medusajs/locking-postgres@2.6.1-snapshot-20250304221555
yarn add @medusajs/locking-redis@2.6.1-snapshot-20250304221555
yarn add @medusajs/notification-local@2.6.1-snapshot-20250304221555
yarn add @medusajs/notification-sendgrid@2.6.1-snapshot-20250304221555
yarn add @medusajs/payment-stripe@2.6.1-snapshot-20250304221555
yarn add @medusajs/region@2.6.1-snapshot-20250304221555
yarn add @medusajs/sales-channel@2.6.1-snapshot-20250304221555
yarn add @medusajs/stock-location@2.6.1-snapshot-20250304221555
yarn add @medusajs/store@2.6.1-snapshot-20250304221555
yarn add @medusajs/tax@2.6.1-snapshot-20250304221555
yarn add @medusajs/user@2.6.1-snapshot-20250304221555
yarn add @medusajs/workflow-engine-inmemory@2.6.1-snapshot-20250304221555
yarn add @medusajs/workflow-engine-redis@2.6.1-snapshot-20250304221555

Latest commit: af613bb

@adrien2p adrien2p changed the title chore(product): Improve product normalization chore(product): Improve product normalization and fix http router with tracing Mar 5, 2025
@adrien2p
Copy link
Member Author

adrien2p commented Mar 5, 2025

/snapshot-this

Copy link
Contributor

github-actions bot commented Mar 5, 2025

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-bundler@2.6.1-snapshot-20250305084453
yarn add @medusajs/admin-sdk@2.6.1-snapshot-20250305084453
yarn add @medusajs/admin-shared@2.6.1-snapshot-20250305084453
yarn add @medusajs/admin-vite-plugin@2.6.1-snapshot-20250305084453
yarn add @medusajs/dashboard@2.6.1-snapshot-20250305084453
yarn add create-medusa-app@2.6.1-snapshot-20250305084453
yarn add @medusajs/cli@2.6.1-snapshot-20250305084453
yarn add medusa-dev-cli@2.6.1-snapshot-20250305084453
yarn add @medusajs/medusa-oas-cli@2.6.1-snapshot-20250305084453
yarn add @medusajs/core-flows@2.6.1-snapshot-20250305084453
yarn add @medusajs/framework@2.6.1-snapshot-20250305084453
yarn add @medusajs/js-sdk@2.6.1-snapshot-20250305084453
yarn add @medusajs/modules-sdk@2.6.1-snapshot-20250305084453
yarn add @medusajs/orchestration@2.6.1-snapshot-20250305084453
yarn add @medusajs/types@2.6.1-snapshot-20250305084453
yarn add @medusajs/utils@2.6.1-snapshot-20250305084453
yarn add @medusajs/workflows-sdk@2.6.1-snapshot-20250305084453
yarn add @medusajs/icons@2.6.1-snapshot-20250305084453
yarn add @medusajs/ui-preset@2.6.1-snapshot-20250305084453
yarn add @medusajs/medusa@2.6.1-snapshot-20250305084453
yarn add @medusajs/telemetry@2.6.1-snapshot-20250305084453
yarn add @medusajs/test-utils@2.6.1-snapshot-20250305084453
yarn add @medusajs/api-key@2.6.1-snapshot-20250305084453
yarn add @medusajs/auth@2.6.1-snapshot-20250305084453
yarn add @medusajs/cache-inmemory@2.6.1-snapshot-20250305084453
yarn add @medusajs/cache-redis@2.6.1-snapshot-20250305084453
yarn add @medusajs/cart@2.6.1-snapshot-20250305084453
yarn add @medusajs/currency@2.6.1-snapshot-20250305084453
yarn add @medusajs/customer@2.6.1-snapshot-20250305084453
yarn add @medusajs/event-bus-local@2.6.1-snapshot-20250305084453
yarn add @medusajs/event-bus-redis@2.6.1-snapshot-20250305084453
yarn add @medusajs/file@2.6.1-snapshot-20250305084453
yarn add @medusajs/fulfillment@2.6.1-snapshot-20250305084453
yarn add @medusajs/index@2.6.1-snapshot-20250305084453
yarn add @medusajs/inventory@2.6.1-snapshot-20250305084453
yarn add @medusajs/link-modules@2.6.1-snapshot-20250305084453
yarn add @medusajs/locking@2.6.1-snapshot-20250305084453
yarn add @medusajs/notification@2.6.1-snapshot-20250305084453
yarn add @medusajs/order@2.6.1-snapshot-20250305084453
yarn add @medusajs/payment@2.6.1-snapshot-20250305084453
yarn add @medusajs/pricing@2.6.1-snapshot-20250305084453
yarn add @medusajs/product@2.6.1-snapshot-20250305084453
yarn add @medusajs/promotion@2.6.1-snapshot-20250305084453
yarn add @medusajs/auth-emailpass@2.6.1-snapshot-20250305084453
yarn add @medusajs/auth-github@2.6.1-snapshot-20250305084453
yarn add @medusajs/auth-google@2.6.1-snapshot-20250305084453
yarn add @medusajs/file-local@2.6.1-snapshot-20250305084453
yarn add @medusajs/file-s3@2.6.1-snapshot-20250305084453
yarn add @medusajs/fulfillment-manual@2.6.1-snapshot-20250305084453
yarn add @medusajs/locking-postgres@2.6.1-snapshot-20250305084453
yarn add @medusajs/locking-redis@2.6.1-snapshot-20250305084453
yarn add @medusajs/notification-local@2.6.1-snapshot-20250305084453
yarn add @medusajs/notification-sendgrid@2.6.1-snapshot-20250305084453
yarn add @medusajs/payment-stripe@2.6.1-snapshot-20250305084453
yarn add @medusajs/region@2.6.1-snapshot-20250305084453
yarn add @medusajs/sales-channel@2.6.1-snapshot-20250305084453
yarn add @medusajs/stock-location@2.6.1-snapshot-20250305084453
yarn add @medusajs/store@2.6.1-snapshot-20250305084453
yarn add @medusajs/tax@2.6.1-snapshot-20250305084453
yarn add @medusajs/user@2.6.1-snapshot-20250305084453
yarn add @medusajs/workflow-engine-inmemory@2.6.1-snapshot-20250305084453
yarn add @medusajs/workflow-engine-redis@2.6.1-snapshot-20250305084453

Latest commit: af613bb

Copy link
Contributor

@thetutlage thetutlage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Router changes looks good

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this to ensure it doesn't happen again?

@adrien2p
Copy link
Member Author

adrien2p commented Mar 5, 2025

@olivermrbl I was on it sorry but I ve pushed now

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM!

@kodiakhq kodiakhq bot merged commit cc1309d into develop Mar 5, 2025
24 checks passed
@kodiakhq kodiakhq bot deleted the chore/improve-product-normalization branch March 5, 2025 13:04
@github-actions github-actions bot mentioned this pull request Mar 5, 2025
@carlos-r-l-rodrigues
Copy link
Contributor

/snapshot-this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants