-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(product): Improve product normalization and fix http router with tracing #11724
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 837be10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@2.6.1-snapshot-20250304214849 yarn add @medusajs/admin-sdk@2.6.1-snapshot-20250304214849 yarn add @medusajs/admin-shared@2.6.1-snapshot-20250304214849 yarn add @medusajs/admin-vite-plugin@2.6.1-snapshot-20250304214849 yarn add @medusajs/dashboard@2.6.1-snapshot-20250304214849 yarn add create-medusa-app@2.6.1-snapshot-20250304214849 yarn add @medusajs/cli@2.6.1-snapshot-20250304214849 yarn add medusa-dev-cli@2.6.1-snapshot-20250304214849 yarn add @medusajs/medusa-oas-cli@2.6.1-snapshot-20250304214849 yarn add @medusajs/core-flows@2.6.1-snapshot-20250304214849 yarn add @medusajs/framework@2.6.1-snapshot-20250304214849 yarn add @medusajs/js-sdk@2.6.1-snapshot-20250304214849 yarn add @medusajs/modules-sdk@2.6.1-snapshot-20250304214849 yarn add @medusajs/orchestration@2.6.1-snapshot-20250304214849 yarn add @medusajs/types@2.6.1-snapshot-20250304214849 yarn add @medusajs/utils@2.6.1-snapshot-20250304214849 yarn add @medusajs/workflows-sdk@2.6.1-snapshot-20250304214849 yarn add @medusajs/icons@2.6.1-snapshot-20250304214849 yarn add @medusajs/ui-preset@2.6.1-snapshot-20250304214849 yarn add @medusajs/medusa@2.6.1-snapshot-20250304214849 yarn add @medusajs/telemetry@2.6.1-snapshot-20250304214849 yarn add @medusajs/test-utils@2.6.1-snapshot-20250304214849 yarn add @medusajs/api-key@2.6.1-snapshot-20250304214849 yarn add @medusajs/auth@2.6.1-snapshot-20250304214849 yarn add @medusajs/cache-inmemory@2.6.1-snapshot-20250304214849 yarn add @medusajs/cache-redis@2.6.1-snapshot-20250304214849 yarn add @medusajs/cart@2.6.1-snapshot-20250304214849 yarn add @medusajs/currency@2.6.1-snapshot-20250304214849 yarn add @medusajs/customer@2.6.1-snapshot-20250304214849 yarn add @medusajs/event-bus-local@2.6.1-snapshot-20250304214849 yarn add @medusajs/event-bus-redis@2.6.1-snapshot-20250304214849 yarn add @medusajs/file@2.6.1-snapshot-20250304214849 yarn add @medusajs/fulfillment@2.6.1-snapshot-20250304214849 yarn add @medusajs/index@2.6.1-snapshot-20250304214849 yarn add @medusajs/inventory@2.6.1-snapshot-20250304214849 yarn add @medusajs/link-modules@2.6.1-snapshot-20250304214849 yarn add @medusajs/locking@2.6.1-snapshot-20250304214849 yarn add @medusajs/notification@2.6.1-snapshot-20250304214849 yarn add @medusajs/order@2.6.1-snapshot-20250304214849 yarn add @medusajs/payment@2.6.1-snapshot-20250304214849 yarn add @medusajs/pricing@2.6.1-snapshot-20250304214849 yarn add @medusajs/product@2.6.1-snapshot-20250304214849 yarn add @medusajs/promotion@2.6.1-snapshot-20250304214849 yarn add @medusajs/auth-emailpass@2.6.1-snapshot-20250304214849 yarn add @medusajs/auth-github@2.6.1-snapshot-20250304214849 yarn add @medusajs/auth-google@2.6.1-snapshot-20250304214849 yarn add @medusajs/file-local@2.6.1-snapshot-20250304214849 yarn add @medusajs/file-s3@2.6.1-snapshot-20250304214849 yarn add @medusajs/fulfillment-manual@2.6.1-snapshot-20250304214849 yarn add @medusajs/locking-postgres@2.6.1-snapshot-20250304214849 yarn add @medusajs/locking-redis@2.6.1-snapshot-20250304214849 yarn add @medusajs/notification-local@2.6.1-snapshot-20250304214849 yarn add @medusajs/notification-sendgrid@2.6.1-snapshot-20250304214849 yarn add @medusajs/payment-stripe@2.6.1-snapshot-20250304214849 yarn add @medusajs/region@2.6.1-snapshot-20250304214849 yarn add @medusajs/sales-channel@2.6.1-snapshot-20250304214849 yarn add @medusajs/stock-location@2.6.1-snapshot-20250304214849 yarn add @medusajs/store@2.6.1-snapshot-20250304214849 yarn add @medusajs/tax@2.6.1-snapshot-20250304214849 yarn add @medusajs/user@2.6.1-snapshot-20250304214849 yarn add @medusajs/workflow-engine-inmemory@2.6.1-snapshot-20250304214849 yarn add @medusajs/workflow-engine-redis@2.6.1-snapshot-20250304214849
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@2.6.1-snapshot-20250304221555 yarn add @medusajs/admin-sdk@2.6.1-snapshot-20250304221555 yarn add @medusajs/admin-shared@2.6.1-snapshot-20250304221555 yarn add @medusajs/admin-vite-plugin@2.6.1-snapshot-20250304221555 yarn add @medusajs/dashboard@2.6.1-snapshot-20250304221555 yarn add create-medusa-app@2.6.1-snapshot-20250304221555 yarn add @medusajs/cli@2.6.1-snapshot-20250304221555 yarn add medusa-dev-cli@2.6.1-snapshot-20250304221555 yarn add @medusajs/medusa-oas-cli@2.6.1-snapshot-20250304221555 yarn add @medusajs/core-flows@2.6.1-snapshot-20250304221555 yarn add @medusajs/framework@2.6.1-snapshot-20250304221555 yarn add @medusajs/js-sdk@2.6.1-snapshot-20250304221555 yarn add @medusajs/modules-sdk@2.6.1-snapshot-20250304221555 yarn add @medusajs/orchestration@2.6.1-snapshot-20250304221555 yarn add @medusajs/types@2.6.1-snapshot-20250304221555 yarn add @medusajs/utils@2.6.1-snapshot-20250304221555 yarn add @medusajs/workflows-sdk@2.6.1-snapshot-20250304221555 yarn add @medusajs/icons@2.6.1-snapshot-20250304221555 yarn add @medusajs/ui-preset@2.6.1-snapshot-20250304221555 yarn add @medusajs/medusa@2.6.1-snapshot-20250304221555 yarn add @medusajs/telemetry@2.6.1-snapshot-20250304221555 yarn add @medusajs/test-utils@2.6.1-snapshot-20250304221555 yarn add @medusajs/api-key@2.6.1-snapshot-20250304221555 yarn add @medusajs/auth@2.6.1-snapshot-20250304221555 yarn add @medusajs/cache-inmemory@2.6.1-snapshot-20250304221555 yarn add @medusajs/cache-redis@2.6.1-snapshot-20250304221555 yarn add @medusajs/cart@2.6.1-snapshot-20250304221555 yarn add @medusajs/currency@2.6.1-snapshot-20250304221555 yarn add @medusajs/customer@2.6.1-snapshot-20250304221555 yarn add @medusajs/event-bus-local@2.6.1-snapshot-20250304221555 yarn add @medusajs/event-bus-redis@2.6.1-snapshot-20250304221555 yarn add @medusajs/file@2.6.1-snapshot-20250304221555 yarn add @medusajs/fulfillment@2.6.1-snapshot-20250304221555 yarn add @medusajs/index@2.6.1-snapshot-20250304221555 yarn add @medusajs/inventory@2.6.1-snapshot-20250304221555 yarn add @medusajs/link-modules@2.6.1-snapshot-20250304221555 yarn add @medusajs/locking@2.6.1-snapshot-20250304221555 yarn add @medusajs/notification@2.6.1-snapshot-20250304221555 yarn add @medusajs/order@2.6.1-snapshot-20250304221555 yarn add @medusajs/payment@2.6.1-snapshot-20250304221555 yarn add @medusajs/pricing@2.6.1-snapshot-20250304221555 yarn add @medusajs/product@2.6.1-snapshot-20250304221555 yarn add @medusajs/promotion@2.6.1-snapshot-20250304221555 yarn add @medusajs/auth-emailpass@2.6.1-snapshot-20250304221555 yarn add @medusajs/auth-github@2.6.1-snapshot-20250304221555 yarn add @medusajs/auth-google@2.6.1-snapshot-20250304221555 yarn add @medusajs/file-local@2.6.1-snapshot-20250304221555 yarn add @medusajs/file-s3@2.6.1-snapshot-20250304221555 yarn add @medusajs/fulfillment-manual@2.6.1-snapshot-20250304221555 yarn add @medusajs/locking-postgres@2.6.1-snapshot-20250304221555 yarn add @medusajs/locking-redis@2.6.1-snapshot-20250304221555 yarn add @medusajs/notification-local@2.6.1-snapshot-20250304221555 yarn add @medusajs/notification-sendgrid@2.6.1-snapshot-20250304221555 yarn add @medusajs/payment-stripe@2.6.1-snapshot-20250304221555 yarn add @medusajs/region@2.6.1-snapshot-20250304221555 yarn add @medusajs/sales-channel@2.6.1-snapshot-20250304221555 yarn add @medusajs/stock-location@2.6.1-snapshot-20250304221555 yarn add @medusajs/store@2.6.1-snapshot-20250304221555 yarn add @medusajs/tax@2.6.1-snapshot-20250304221555 yarn add @medusajs/user@2.6.1-snapshot-20250304221555 yarn add @medusajs/workflow-engine-inmemory@2.6.1-snapshot-20250304221555 yarn add @medusajs/workflow-engine-redis@2.6.1-snapshot-20250304221555
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@2.6.1-snapshot-20250305084453 yarn add @medusajs/admin-sdk@2.6.1-snapshot-20250305084453 yarn add @medusajs/admin-shared@2.6.1-snapshot-20250305084453 yarn add @medusajs/admin-vite-plugin@2.6.1-snapshot-20250305084453 yarn add @medusajs/dashboard@2.6.1-snapshot-20250305084453 yarn add create-medusa-app@2.6.1-snapshot-20250305084453 yarn add @medusajs/cli@2.6.1-snapshot-20250305084453 yarn add medusa-dev-cli@2.6.1-snapshot-20250305084453 yarn add @medusajs/medusa-oas-cli@2.6.1-snapshot-20250305084453 yarn add @medusajs/core-flows@2.6.1-snapshot-20250305084453 yarn add @medusajs/framework@2.6.1-snapshot-20250305084453 yarn add @medusajs/js-sdk@2.6.1-snapshot-20250305084453 yarn add @medusajs/modules-sdk@2.6.1-snapshot-20250305084453 yarn add @medusajs/orchestration@2.6.1-snapshot-20250305084453 yarn add @medusajs/types@2.6.1-snapshot-20250305084453 yarn add @medusajs/utils@2.6.1-snapshot-20250305084453 yarn add @medusajs/workflows-sdk@2.6.1-snapshot-20250305084453 yarn add @medusajs/icons@2.6.1-snapshot-20250305084453 yarn add @medusajs/ui-preset@2.6.1-snapshot-20250305084453 yarn add @medusajs/medusa@2.6.1-snapshot-20250305084453 yarn add @medusajs/telemetry@2.6.1-snapshot-20250305084453 yarn add @medusajs/test-utils@2.6.1-snapshot-20250305084453 yarn add @medusajs/api-key@2.6.1-snapshot-20250305084453 yarn add @medusajs/auth@2.6.1-snapshot-20250305084453 yarn add @medusajs/cache-inmemory@2.6.1-snapshot-20250305084453 yarn add @medusajs/cache-redis@2.6.1-snapshot-20250305084453 yarn add @medusajs/cart@2.6.1-snapshot-20250305084453 yarn add @medusajs/currency@2.6.1-snapshot-20250305084453 yarn add @medusajs/customer@2.6.1-snapshot-20250305084453 yarn add @medusajs/event-bus-local@2.6.1-snapshot-20250305084453 yarn add @medusajs/event-bus-redis@2.6.1-snapshot-20250305084453 yarn add @medusajs/file@2.6.1-snapshot-20250305084453 yarn add @medusajs/fulfillment@2.6.1-snapshot-20250305084453 yarn add @medusajs/index@2.6.1-snapshot-20250305084453 yarn add @medusajs/inventory@2.6.1-snapshot-20250305084453 yarn add @medusajs/link-modules@2.6.1-snapshot-20250305084453 yarn add @medusajs/locking@2.6.1-snapshot-20250305084453 yarn add @medusajs/notification@2.6.1-snapshot-20250305084453 yarn add @medusajs/order@2.6.1-snapshot-20250305084453 yarn add @medusajs/payment@2.6.1-snapshot-20250305084453 yarn add @medusajs/pricing@2.6.1-snapshot-20250305084453 yarn add @medusajs/product@2.6.1-snapshot-20250305084453 yarn add @medusajs/promotion@2.6.1-snapshot-20250305084453 yarn add @medusajs/auth-emailpass@2.6.1-snapshot-20250305084453 yarn add @medusajs/auth-github@2.6.1-snapshot-20250305084453 yarn add @medusajs/auth-google@2.6.1-snapshot-20250305084453 yarn add @medusajs/file-local@2.6.1-snapshot-20250305084453 yarn add @medusajs/file-s3@2.6.1-snapshot-20250305084453 yarn add @medusajs/fulfillment-manual@2.6.1-snapshot-20250305084453 yarn add @medusajs/locking-postgres@2.6.1-snapshot-20250305084453 yarn add @medusajs/locking-redis@2.6.1-snapshot-20250305084453 yarn add @medusajs/notification-local@2.6.1-snapshot-20250305084453 yarn add @medusajs/notification-sendgrid@2.6.1-snapshot-20250305084453 yarn add @medusajs/payment-stripe@2.6.1-snapshot-20250305084453 yarn add @medusajs/region@2.6.1-snapshot-20250305084453 yarn add @medusajs/sales-channel@2.6.1-snapshot-20250305084453 yarn add @medusajs/stock-location@2.6.1-snapshot-20250305084453 yarn add @medusajs/store@2.6.1-snapshot-20250305084453 yarn add @medusajs/tax@2.6.1-snapshot-20250305084453 yarn add @medusajs/user@2.6.1-snapshot-20250305084453 yarn add @medusajs/workflow-engine-inmemory@2.6.1-snapshot-20250305084453 yarn add @medusajs/workflow-engine-redis@2.6.1-snapshot-20250305084453
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Router changes looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for this to ensure it doesn't happen again?
@olivermrbl I was on it sorry but I ve pushed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice LGTM!
/snapshot-this |
What