Skip to content

Edit room name within explore #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Edit room name within explore #177

wants to merge 4 commits into from

Conversation

aofn
Copy link
Member

@aofn aofn commented Nov 27, 2024

Adds a component to explore settings to let users change the name of a space/room.

The room name in the header of explore is usually one step behind. This was a problem we encountered and weren't able to find the solution so far. Sometihing within lib/Matrix.js doesn't seem to fire when changing the name or is just one step behind.

users are therefore prompted to reload the page in order for changes to take (visual) effect

@aofn aofn mentioned this pull request Nov 27, 2024
@robertschnuell
Copy link
Member

sadly this PR does not work on my machine. even after a clean install I always get the error: TypeError: Cannot read properties of undefined (reading 'getMatrixClient') in file lib/Matrix.js (10:48) @ getMatrixClient. private session or clearing all localstorage does not solve the problem either.
any idea why this isnt working?

@aofn
Copy link
Member Author

aofn commented Dec 4, 2024

hm just tested this again and it was working on my side. Does everything else work normally? Does auth work fine? Because the error kind of sounds like the matrixClient isn't initialised or something like that, since it's pointing to lib/Matrix.js. Does the console give any more detais?

@robertschnuell
Copy link
Member

seems like your other PR somehow works without any next.js config, but this one does not. anyhow that was the problem that this file went missing. sorry for that, the origin of the problem seemed to be infront of the computer.

aofn added 2 commits December 5, 2024 14:00
…This should be handled by `lib/Matrix.js` but there seems to be a state not updating correctly (most likely `cachedSpaces` in `explore/[roomId].js`. So as a workaround this method is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants