Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/did: Support service / controller / various verificationRelationship in DID Document #98

Merged
merged 1 commit into from
Apr 26, 2021
Merged

x/did: Support service / controller / various verificationRelationship in DID Document #98

merged 1 commit into from
Apr 26, 2021

Conversation

youngjoon-lee
Copy link
Contributor

@youngjoon-lee youngjoon-lee commented Apr 19, 2021 •
edited
Loading

Closes #48

  • Now, DID Document can contain (according to the semi-finalized new DID spec)
    • controller
    • service
    • assertionMethod: essential for VC/VP verification using the vc-service
    • keyAgreement
    • capabilityInvocation
    • capabilityDelegation

@youngjoon-lee youngjoon-lee requested a review from cl9200 April 19, 2021 09:58
@youngjoon-lee youngjoon-lee marked this pull request as draft April 19, 2021 10:01
@youngjoon-lee youngjoon-lee force-pushed the ft/48/assertion-method branch from 8b89957 to 08dda26 Compare April 20, 2021 02:35
@youngjoon-lee youngjoon-lee changed the title x/did: Support various verificationRelationship in DID Document x/did: Support service / controller / various verificationRelationship in DID Document Apr 20, 2021
@youngjoon-lee youngjoon-lee marked this pull request as ready for review April 20, 2021 02:38
cl9200
cl9200 approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@cl9200 cl9200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngjoon-lee youngjoon-lee merged commit 55860dc into master Apr 26, 2021
@youngjoon-lee youngjoon-lee deleted the ft/48/assertion-method branch April 26, 2021 07:16
@audtlr24 audtlr24 mentioned this pull request Mar 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cl9200 cl9200 cl9200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the assertionMethod for Verifiable Credentials
2 participants
@youngjoon-lee @cl9200