Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update gitbook to panacea v2 #165

Merged
merged 5 commits into from
Jul 9, 2021
Merged

feat: Update gitbook to panacea v2 #165

merged 5 commits into from
Jul 9, 2021

Conversation

gyuguen
Copy link
Contributor

@gyuguen gyuguen commented Jul 7, 2021

The gitbook document has also been modified with Panacea v2

gyuguen added 3 commits July 5, 2021 09:48
* feat: Add git flow to make docker image

* feat: change version docker-publish modules
@gyuguen gyuguen requested a review from youngjoon-lee July 7, 2021 07:08
@gyuguen gyuguen requested a review from cl9200 as a code owner July 7, 2021 07:08

Install the latest version of Panacea Core.

```bash
git clone https://github.com/medibloc/panacea-core
cd panacea-core
git checkout v1.3.3
git checkout v2.0.0-alpha.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking about whether to change this version to the official version(v2.0.0)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that v2.0.0-alpha.1 is good. When we release next versions, we should keep in mind that this doc also should be updated.

@gyuguen
Copy link
Contributor Author

gyuguen commented Jul 7, 2021

I think it don't use this anymore. Please let me know if I can delete it. (@youngjoon-lee )
.gitbook/guide/light-client-daemon.md

@youngjoon-lee
Copy link
Contributor

I think it don't use this anymore. Please let me know if I can delete it. (@youngjoon-lee )

.gitbook/guide/light-client-daemon.md

Yes. I think we can delete it. :)

@gyuguen
Copy link
Contributor Author

gyuguen commented Jul 7, 2021

I think it don't use this anymore. Please let me know if I can delete it. (@youngjoon-lee )
.gitbook/guide/light-client-daemon.md

Yes. I think we can delete it. :)

Thank you for your reply. I deleted it

@youngjoon-lee youngjoon-lee linked an issue Jul 8, 2021 that may be closed by this pull request
Comment on lines -183 to +193
Each tag is conformed by a key-value pair in the form of `<tag>:<value>`. Tags can also be combined to query for a more specific result using the `&` symbol.
Events are implemented in the Cosmos SDK as an alias of the ABCI `Event` type and take the form of: `{eventType}.{attributeKey}={attributeValue}`. Events can also be combined to query for a more specific result using the `&` symbol.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@gyuguen gyuguen merged commit 6c6abc5 into medibloc:master Jul 9, 2021
@youngjoon-lee youngjoon-lee added this to the v2.0.0 milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Gitbook for Panacea v2
2 participants