feat: Add git flow to make docker image #157
Conversation
.github/workflows/docker-publish.yml
Outdated
| # https://github.com/docker/login-action | ||
| - name: Log into registry ${{ env.REGISTRY }} | ||
| if: github.event_name != 'pull_request' | ||
| uses: docker/login-action@28218f9b04b4f3f62068d7b6ce6ca5b26e35336c |
There was a problem hiding this comment.
Is there any reason why use a specific commit hash instead of the semver docker/login-action@v1?
There was a problem hiding this comment.
This is an automatically generated hash.
I will test it after changing it to the latest version!
There was a problem hiding this comment.
I updated current tag and the test result was successful in upload the git package.
Thank you review.
| RUN make clean && make build | ||
|
|
||
| # Get 'libwasmvm.so' from wasmvm | ||
| RUN git clone -b v0.14.0 https://github.com/CosmWasm/wasmvm.git /src/wasmvm |
There was a problem hiding this comment.
Yeah. There's no other way to get libwasmvm.so because CosmWasm/wasmvm is indirectly referred by panacea-core (The panacea-core refers to CosmWasm/wasmd which refers to CosmWasm/wasmvm).
Now, we must keep in mind that the version of wasmvm must be always updated whenever we update the wasmd (in the go.mod).
Btw, I just found that the wasmvm also provides a libwasmvm_muslc.a for Alpine Linux.
https://github.com/CosmWasm/wasmd/blob/d2e35c249e39e90c5a85e03e0b75800431612b20/Dockerfile#L18
It would be better to use that, but not for now because that's a static library (not a shared library). It means that we have to change our Makefile to build the panacead with the static library. So, let's do it later. For now, your strategy is good enough.
| RUN make clean && make build | ||
|
|
||
| # Get 'libwasmvm.so' from wasmvm | ||
| RUN git clone -b v0.14.0 https://github.com/CosmWasm/wasmvm.git /src/wasmvm |
There was a problem hiding this comment.
It is same version used by wasmd(v0.17.0)
If change the wasmd version, wasmvm version needs to be update too.
| context: . | ||
| push: ${{ github.event_name != 'pull_request' }} | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} |
There was a problem hiding this comment.
Aha. I got it.
To check if I understood it correctly, the docker image will be pushed:
- When the
masterbranch is updated, an image is pushed with the tagmaster. - Or,
- When the
vX.Y.Zgit tag is created, an image is pushed with the tagvX.Y.Zand thelatestdocker tag is updated.
Is it right?
There was a problem hiding this comment.
That's right.�
I test my packages.
When master branch changed and add new tag then build docker image and publish git package.
There were a few things to consider.
libwasmvm.solibrary