Update postfix headers #771
Conversation
|
Is this ready for review? I see the CI failing for whatever reason. |
apps/topics-map/Dockerfile
Outdated
| @@ -5,7 +5,10 @@ | |||
| FROM gcr.io/mcback/common:latest | |||
|
|
|||
| # Install Java | |||
| RUN apt-get -y --no-install-recommends install openjdk-8-jre-headless | |||
| RUN \ | |||
| apt-get update && \ | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Could you add a quick -y flag here, as in apt-get -y update? The update sub-command typically doesn't ask for questions but it might (I suppose), or (maybe) I have even seen it asking me for something, so it wouldn't hurt to have a -y here just like everywhere else.
|
Headers looking good now:
|
|
The failing test here is related to Brandwatch: https://github.com/mediacloud/backend/pull/771/checks?check_run_id=1938298020#step:16:2177 I don't think it's related to any of my changes, but I can take a stab at fixing it before merging if you'd like. |
apps/topics-map/Dockerfile
Outdated
| @@ -5,7 +5,10 @@ | |||
| FROM gcr.io/mcback/common:latest | |||
|
|
|||
| # Install Java | |||
| RUN apt-get -y --no-install-recommends install openjdk-8-jre-headless | |||
| RUN \ | |||
| apt-get update && \ | |||
There was a problem hiding this comment.
Could you add a quick -y flag here, as in apt-get -y update? The update sub-command typically doesn't ask for questions but it might (I suppose), or (maybe) I have even seen it asking me for something, so it wouldn't hurt to have a -y here just like everywhere else.
|
alrighty, i think all set (save for adding the |
|
All good now, thank you James! |
Message-Id+Dateare now working in my testing. I can't getList-Unsubscribeto show up despite having followed the guidance at these links:https://blog.mailtrap.io/list-unsubscribe-header/
https://www.reddit.com/r/postfix/comments/a8p1m7/custom_header/eccyorb?utm_source=share&utm_medium=web2x&context=3
I've been banging my head against this for a while, so if you've got any ideas about the
List-Unsubscribeheader thing, that'd be great. I'm also fine with just forgetting about it given that our updated messages seem no longer to be flagged as spam.