Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UIEvent.cancelBubble #7360

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Remove UIEvent.cancelBubble #7360

merged 1 commit into from
Dec 18, 2020

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
    • data:text/html,<script>alert("cancelBubble" in UIEvent.prototype)</script> via mozregression
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: closes Remove UIEvent.cancelBubble #7350

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 14, 2020
@saschanaz saschanaz mentioned this pull request Nov 18, 2020
Closed
ddbeck
ddbeck approved these changes Dec 18, 2020
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit d971fd1 into mdn:master Dec 18, 2020
@saschanaz saschanaz deleted the cancelbubble branch December 18, 2020 18:15
foolip
foolip reviewed Dec 18, 2020
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I had a pending comment/suggestion.

api/Event.json
},
{
"version_added": "1",
"notes": "This property was defined on the <a href='https://developer.mozilla.org/docs/Web/API/UIEvent'><code>UIEvent</code></a> interface."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording I suggest in #7517 would be "Only supported for UIEvent, not all Event objects."

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Dec 19, 2020
@ddbeck
Correct note text for cancelBubble prototype move
37993f2 
This is a follow up to mdn#7360. It rewrites the notes to use the model
text in mdn#7517.
@ddbeck ddbeck mentioned this pull request Dec 19, 2020
Merged
@ddbeck
Copy link
Collaborator

ddbeck commented Dec 19, 2020

@foolip Sorry for moving ahead prematurely on that. I opened #8040.

foolip pushed a commit that referenced this pull request Dec 19, 2020
@ddbeck
Correct note text for cancelBubble prototype move (#8040)
252d5d5 
This is a follow up to #7360. It rewrites the notes to use the model
text in #7517.

* Correct note text for cancelBubble prototype move
* Add partial_implementation and version_removed
@foolip
Copy link
Contributor

foolip commented Dec 19, 2020

@ddbeck I hasn't submitted the review, so it was my mistake. Thanks for fixing nevertheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip left review comments

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove UIEvent.cancelBubble
4 participants
@saschanaz @ddbeck @foolip @queengooborg